Skip to content

[release-ocm-2.12] MGMT-19194: Save Agent inventory and status in annotation - #6968

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-ocm-2.12from
openshift-cherrypick-robot:cherry-pick-6957-to-release-ocm-2.12
Nov 5, 2024
Merged

[release-ocm-2.12] MGMT-19194: Save Agent inventory and status in annotation#6968
openshift-merge-bot[bot] merged 1 commit into
openshift:release-ocm-2.12from
openshift-cherrypick-robot:cherry-pick-6957-to-release-ocm-2.12

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Nov 4, 2024

Copy link
Copy Markdown

This is an automated cherry-pick of #6957

/assign CrystalChun

@CrystalChun openshift-cherrypick-robot
MGMT-19194: Save Agent inventory and status in annotation
996dea5 
For Hypershift's backup and restore of hosted cluster
from one hub to a new hub, the Agent requires these
status fields to be restored in order for the NodePool
to successfully re-adopt the Nodes for the hosted cluster.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 4, 2024
Merged
6 of 20 tasks
@openshift-ci-robot

openshift-ci-robot commented Nov 4, 2024 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-19194

Details

In response to this:

This is an automated cherry-pick of #6957

/assign CrystalChun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 4, 2024
@openshift-ci
openshift-ci Bot requested review from eifrach and gamli75 November 4, 2024 20:38
@codecov

codecov Bot commented Nov 4, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.68%. Comparing base (3c80e5b) to head (996dea5).
Report is 1 commits behind head on release-ocm-2.12.

Files with missing lines Patch % Lines
...nternal/controller/controllers/agent_controller.go 93.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           release-ocm-2.12    #6968      +/-   ##
====================================================
- Coverage             68.68%   68.68%   -0.01%     
====================================================
  Files                   249      249              
  Lines                 37325    37327       +2     
====================================================
+ Hits                  25636    25637       +1     
- Misses                 9396     9397       +1     
  Partials               2293     2293
Files with missing lines Coverage Δ
...nternal/controller/controllers/agent_controller.go 76.45% <93.33%> (+0.20%) ⬆️

... and 2 files with indirect coverage changes

@CrystalChun

CrystalChun commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

/retest

@CrystalChun CrystalChun mentioned this pull request Nov 5, 2024
Closed
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2024
@gamli75

gamli75 commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Nov 5, 2024 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@gamli75: This pull request references MGMT-19194 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 5, 2024
@openshift-ci

openshift-ci Bot commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@openshift-merge-bot
openshift-merge-bot Bot merged commit 0aeb118 into openshift:release-ocm-2.12 Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gamli75 gamli75 gamli75 approved these changes
@eifrach eifrach Awaiting requested review from eifrach

Assignees

@CrystalChun CrystalChun

@gamli75 gamli75

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @openshift-ci-robot @CrystalChun @gamli75