[release-ocm-2.10] MGMT-18584: Fix AutomatedCleaningMode behavior

[openshift-cherrypick-robot]

This is an automated cherry-pick of #6662

/assign CrystalChun

/cherrypick release-ocm-2.9

[openshift-ci-robot]

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-18560

Details

In response to this:

This is an automated cherry-pick of #6662

/assign CrystalChun

/cherrypick release-ocm-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[CrystalChun]

/retitle [release-ocm-2.10] MGMT-18584: Fix AutomatedCleaningMode behavior

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references MGMT-18584 which is a valid jira issue.

Details

In response to this:

This is an automated cherry-pick of #6662

/assign CrystalChun

/cherrypick release-ocm-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[CrystalChun]

/uncc @oourfali @romfreiman
/cc @gamli75

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.30%. Comparing base (a26367d) to head (35d1010).

Additional details and impacted files

@@                 Coverage Diff                  @@
##           release-ocm-2.10    #6668      +/-   ##
====================================================
+ Coverage             68.29%   68.30%   +0.01%     
====================================================
  Files                   236      236              
  Lines                 35093    35096       +3     
====================================================
+ Hits                  23968    23974       +6     
+ Misses                 9051     9049       -2     
+ Partials               2074     2073       -1     

Files	Coverage Δ
...nal/controller/controllers/bmh_agent_controller.go	76.48% <100.00%> (+0.07%)	⬆️

... and 2 files with indirect coverage changes

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [gamli75]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-cherrypick-robot]

@openshift-cherrypick-robot: #6668 failed to apply on top of branch "release-ocm-2.9":

Applying: MGMT-18560: Fix AutomatedCleaningMode behavior
Using index info to reconstruct a base tree...
M	internal/controller/controllers/bmh_agent_controller.go
M	internal/controller/controllers/bmh_agent_controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging internal/controller/controllers/bmh_agent_controller_test.go
CONFLICT (content): Merge conflict in internal/controller/controllers/bmh_agent_controller_test.go
Auto-merging internal/controller/controllers/bmh_agent_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 MGMT-18560: Fix AutomatedCleaningMode behavior
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

This is an automated cherry-pick of #6662

/assign CrystalChun

/cherrypick release-ocm-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.