Skip to content

[release-ocm-2.9] MGMT-18313: Replace golang base image as it is based on Centos Linux 7 - #6656

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-ocm-2.9from
danmanor:replace-base-image-2.9
Aug 7, 2024
Merged

[release-ocm-2.9] MGMT-18313: Replace golang base image as it is based on Centos Linux 7#6656
openshift-merge-bot[bot] merged 1 commit into
openshift:release-ocm-2.9from
danmanor:replace-base-image-2.9

Conversation

@danmanor

@danmanor danmanor commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

Backport of #6637

@openshift-ci-robot

openshift-ci-robot commented Aug 6, 2024 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@danmanor: This pull request references MGMT-18313 which is a valid jira issue.

Details

In response to this:

Backport of #6637

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 6, 2024
@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 6, 2024
@openshift-ci openshift-ci Bot added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Aug 6, 2024
@openshift-ci

openshift-ci Bot commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2024
@danmanor
danmanor force-pushed the replace-base-image-2.9 branch from 0bd5eb6 to 0d19288 Compare August 6, 2024 10:35
@danmanor

danmanor commented Aug 6, 2024

Copy link
Copy Markdown
Contributor Author

/cc @eifrach

@danmanor

danmanor commented Aug 6, 2024

Copy link
Copy Markdown
Contributor Author

/cc @adriengentil

@openshift-ci
openshift-ci Bot requested a review from eifrach August 6, 2024 10:37
@codecov

codecov Bot commented Aug 6, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.67%. Comparing base (de606fd) to head (a922cf3).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-ocm-2.9    #6656      +/-   ##
===================================================
- Coverage            67.68%   67.67%   -0.01%     
===================================================
  Files                  232      232              
  Lines                34119    34119              
===================================================
- Hits                 23093    23090       -3     
- Misses                8979     8980       +1     
- Partials              2047     2049       +2

see 1 file with indirect coverage changes

@danmanor
danmanor force-pushed the replace-base-image-2.9 branch from 0d19288 to 13087c8 Compare August 6, 2024 11:28
@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2024
@danmanor

danmanor commented Aug 6, 2024

Copy link
Copy Markdown
Contributor Author

/retest

@danmanor
danmanor force-pushed the replace-base-image-2.9 branch from 13087c8 to a922cf3 Compare August 7, 2024 07:09
@openshift-ci

openshift-ci Bot commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eifrach

eifrach commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
@openshift-merge-bot
openshift-merge-bot Bot merged commit e8ff318 into openshift:release-ocm-2.9 Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adriengentil adriengentil Awaiting requested review from adriengentil
@rccrdpccl rccrdpccl Awaiting requested review from rccrdpccl
@eifrach eifrach Awaiting requested review from eifrach

Assignees

@eifrach eifrach

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danmanor @openshift-ci-robot @eifrach