Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/user-guide/support-level.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ When adding a new feature to the feature-usage API, it is not necessary to add t
## Adding a new feature
To add a new feature to the support-level API, follow these steps:
1. Add a new enum to `feature-support-level-id` under the `swagger.yaml` file - [here](https://github.com/openshift/assisted-service/blob/master/swagger.yaml#L3910-#L3924)
2. Generate `models` and `vendor` files - `skipper make generate-from-swagger && skipper make generate-vendor`
2. Generate `models` and `vendor` files - `skipper make generate-from-swagger && skipper make generate-go`
3. Create a new struct that represent the new feature and follows the `SupportLevelFeature` [interface](https://github.com/openshift/assisted-service/blob/master/internal/featuresupport/features.go#L18-#L25)
4. Initiate the new object on [featuresList](https://github.com/openshift/assisted-service/blob/master/internal/featuresupport/feature_support_level.go#L13)
map and map the newly generated feature-id to the new object.
Expand Down
14 changes: 7 additions & 7 deletions hack/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@ generate-bundle:

generate-from-swagger: lint-swagger generate-go-client generate-go-server validate-swagger-file --remove-dashes-and-dots

generate-vendor:
go mod vendor
cd api && go mod vendor
cd client && go mod vendor
cd models && go mod vendor
generate-go:
go mod tidy && go mod vendor
cd api && go mod tidy && go mod vendor
cd client && go mod tidy && go mod vendor
cd models && go mod tidy && go mod vendor

# Note that generate-from-swagger is intentionally before generate-vendor
# Note that generate-from-swagger is intentionally before generate-go
# because the latter copies around files that need to be generated by the
# former. Without doing it in this order, the `generate` target will not be
# idempotent and would have to be executed twice to achieve the desired result.
generate: generate-from-swagger generate-vendor generate-events generate-mocks generate-configuration generate-bundle
generate: generate-from-swagger generate-go generate-events generate-mocks generate-configuration generate-bundle