Skip to content

NO-ISSUE: Increase Konflux git clone depth - #6496

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:cloud_hotfix_releasesfrom
pastequo:konflux/fix-depth-hotfix
Jun 27, 2024
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:cloud_hotfix_releasesfrom
pastequo:konflux/fix-depth-hotfix

Conversation

@pastequo

Copy link
Copy Markdown
Contributor

@danmanor

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 27, 2024
@openshift-ci-robot

Copy link
Copy Markdown

@pastequo: This pull request explicitly references no jira issue.

Details

In response to this:

@danmanor

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2024
@openshift-ci
openshift-ci Bot requested review from omertuc and rccrdpccl June 27, 2024 10:19
@danmanor

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
@danmanor

Copy link
Copy Markdown
Contributor

/retest

@danmanor

Copy link
Copy Markdown
Contributor

/override ci/prow/e2e-metal-assisted-day2 ci/prow/e2e-metal-assisted-ipv4v6
ci/prow/e2e-metal-assisted-onprem ci/prow/e2e-metal-assisted-single-node
ci/prow/e2e-metal-assisted-static-ip-suite

@openshift-ci

openshift-ci Bot commented Jun 27, 2024

Copy link
Copy Markdown
Contributor

@danmanor: Overrode contexts on behalf of danmanor: ci/prow/e2e-metal-assisted-day2, ci/prow/e2e-metal-assisted-ipv4v6

Details

In response to this:

/override ci/prow/e2e-metal-assisted-day2 ci/prow/e2e-metal-assisted-ipv4v6
ci/prow/e2e-metal-assisted-onprem ci/prow/e2e-metal-assisted-single-node
ci/prow/e2e-metal-assisted-static-ip-suite

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@danmanor

Copy link
Copy Markdown
Contributor

/override
ci/prow/e2e-metal-assisted-onprem ci/prow/e2e-metal-assisted-single-node ci/prow/e2e-metal-assisted-static-ip-suite ci/prow/unit-test

@codecov

codecov Bot commented Jun 27, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.20%. Comparing base (ef0c961) to head (2ae64f9).
Report is 999 commits behind head on cloud_hotfix_releases.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##           cloud_hotfix_releases    #6496      +/-   ##
=========================================================
+ Coverage                  66.66%   68.20%   +1.53%     
=========================================================
  Files                        197      242      +45     
  Lines                      27526    35869    +8343     
=========================================================
+ Hits                       18350    24463    +6113     
- Misses                      7531     9279    +1748     
- Partials                    1645     2127     +482     

see 161 files with indirect coverage changes

@danmanor

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jun 27, 2024

Copy link
Copy Markdown
Contributor

@pastequo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci

openshift-ci Bot commented Jun 27, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, pastequo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@openshift-merge-bot
openshift-merge-bot Bot merged commit ab03251 into openshift:cloud_hotfix_releases Jun 27, 2024
@pastequo
pastequo deleted the konflux/fix-depth-hotfix branch June 27, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants