Skip to content

[cloud_hotfix_releases] OCPBUGS-31733: Remove CPMS manifest for vSphere platform - #6404

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:cloud_hotfix_releasesfrom
openshift-cherrypick-robot:cherry-pick-6239-to-cloud_hotfix_releases
Jun 5, 2024
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:cloud_hotfix_releasesfrom
openshift-cherrypick-robot:cherry-pick-6239-to-cloud_hotfix_releases

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #6239

/assign gamli75

The control-plane-machine-set (CPMS) cluster operator fails to deploy
on 4.16-ec.5 build for ABI deployments on vSphere.
That build removed the CPMS feature gate.

Because ABI and assisted deployments do not create or include
machines in the manifests, and the control plane machine operator
expects machines to be present for each control plane node, the
CO fails to deploy.

The CPMS manifest should be removed for ABI and other UPI-like
deployments.

For UPI there is documentation indicating the CPMS manifest must
be removed: https://docs.openshift.com/container-platform/4.15/installing/installing_vsphere/upi/installing-vsphere.html#installation-user-infra-generate-k8s-manifest-ignition_installing-vsphere
@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-31733 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

Details

In response to this:

This is an automated cherry-pick of #6239

/assign gamli75

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 5, 2024
@openshift-ci-robot

Copy link
Copy Markdown

@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-31733, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-31733 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-31733 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

In response to this:

This is an automated cherry-pick of #6239

/assign gamli75

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. lgtm Indicates that a PR is ready to be merged. labels Jun 5, 2024
@openshift-ci
openshift-ci Bot requested review from eliorerz and javipolo June 5, 2024 12:32
@openshift-ci

openshift-ci Bot commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci

openshift-ci Bot commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2024
@codecov

codecov Bot commented Jun 5, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.21%. Comparing base (ef0c961) to head (e376ac1).
Report is 997 commits behind head on cloud_hotfix_releases.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##           cloud_hotfix_releases    #6404      +/-   ##
=========================================================
+ Coverage                  66.66%   68.21%   +1.55%     
=========================================================
  Files                        197      242      +45     
  Lines                      27526    35869    +8343     
=========================================================
+ Hits                       18350    24468    +6118     
- Misses                      7531     9276    +1745     
- Partials                    1645     2125     +480     
Files Coverage Δ
internal/provider/vsphere/ignition.go 0.00% <0.00%> (ø)

... and 160 files with indirect coverage changes

@adriengentil adriengentil removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 5, 2024
@openshift-ci

openshift-ci Bot commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 0f3ad25 into openshift:cloud_hotfix_releases Jun 5, 2024
@openshift-ci-robot

Copy link
Copy Markdown

@openshift-cherrypick-robot: Jira Issue OCPBUGS-31733 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #6239

/assign gamli75

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants