MULTIARCH-4515: Bump version dependency.

[AmadeusPodvratnik]

Bump version for MULTIARCH-4515: Add support for ins-file as boot artefact.

go get github.com/openshift/assisted-image-service@d3f8a0398019e0858bf78319156249218912ce09
go mod tidy
go mod vendor

List all the issues related to this PR

• [] New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@AmadeusPodvratnik: This pull request references MULTIARCH-4515 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Bump version for MULTIARCH-4515: Add support for ins-file as boot artefact.

go get github.com/openshift/assisted-image-service@d3f8a0398019e0858bf78319156249218912ce09
go mod tidy
go mod vendor

List all the issues related to this PR

• [] New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[omertuc]

/lgtm

[omertuc]

/approve

[omertuc]

/ok-to-test

[omertuc]

Hopefully the gomega bump won't lead to any test failures...

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD ffa8b5c and 2 for PR HEAD b8ad3de8431ff257834531202f4bdd8954449b79 in total

[AmadeusPodvratnik]

@omertuc I see some test failures ... just checking if this is related to gomega ...

What I found so far is this:
https://github.com/prometheus/client_golang/releases/tag/v1.19.0
there is an issue with prometheus/common and client_golang but the versions inside go.mod shows the requried version.

[omertuc]

The issues are due to the image-service repo having go 1.21 while the assisted-service repo has go 1.20

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.43%. Comparing base (780deff) to head (3103d30).
Report is 213 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #6373    +/-   ##
========================================
  Coverage   68.43%   68.43%            
========================================
  Files         244      247     +3     
  Lines       35999    36230   +231     
========================================
+ Hits        24635    24795   +160     
- Misses       9191     9235    +44     
- Partials     2173     2200    +27     

see 20 files with indirect coverage changes

[AmadeusPodvratnik]

/retest-required

[AmadeusPodvratnik]

/retest-required

[AmadeusPodvratnik]

/test edge-images

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AmadeusPodvratnik, omertuc, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [omertuc,rccrdpccl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rccrdpccl]

/retest

[rccrdpccl]

@carbonin we will need to change golang version is CI as well (this and more)

Btw good point, I think we need to get some other changes in.

@AmadeusPodvratnik can you please change Golang version in dockerfiles (ci-images/ and root dir)?

[rccrdpccl]

/hold

[gamli75]

@eifrach please review

[gamli75]

cc @adriengentil @rccrdpccl @gamli75 do we require anything outside of this for a golang version bump?

let's change the go version in the DS images as well
https://gitlab.cee.redhat.com/rh-ecosystem-edge/assisted-installer/assisted-installer-projects/-/blob/rhai-1.0-rhel-8/distgit/containers/assisted-service/Dockerfile.in?ref_type=heads

@eifrach has a task to do it in all our repositories - I asked him to review it as well.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[AmadeusPodvratnik]

@rccrdpccl I just updated the golang to 1.21 for root docker files and the ci-images.

[AmadeusPodvratnik]

/retest

[AmadeusPodvratnik]

/retest

[AmadeusPodvratnik]

/retest

[AmadeusPodvratnik]

/retest

[AmadeusPodvratnik]

/retest

[AmadeusPodvratnik]

/retest

[openshift-merge-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[AmadeusPodvratnik]

/retest

[eifrach]

@AmadeusPodvratnik can you rebase it with the master?

there are a few changes witht the linter / unit-test that may be missing here
#6667

[openshift-ci]

@AmadeusPodvratnik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-unit-test	3103d30	link	true	/test edge-unit-test
ci/prow/edge-lint	3103d30	link	true	/test edge-lint
ci/prow/edge-e2e-metal-assisted-cnv-4-16	3103d30	link	true	/test edge-e2e-metal-assisted-cnv-4-16
ci/prow/edge-e2e-metal-assisted-odf-4-16	3103d30	link	true	/test edge-e2e-metal-assisted-odf-4-16
ci/prow/edge-e2e-metal-assisted-odf-4-17	3103d30	link	true	/test edge-e2e-metal-assisted-odf-4-17
ci/prow/edge-e2e-metal-assisted-cnv-4-17	3103d30	link	true	/test edge-e2e-metal-assisted-cnv-4-17

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[rccrdpccl]

@AmadeusPodvratnik can we close this?

[AmadeusPodvratnik]

Bump is not necessary ...