NO-ISSUE: add registry.ci.openshift.org to PUBLIC_CONTAINER_REGISTRIES

[fiblan]

Added registry registry.ci.openshift.org to PUBLIC_CONTAINER_REGISTRIES to bypass auth registry validation via validations.ParsePublicRegistries

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@fiblan: This pull request explicitly references no jira issue.

In response to this:

Added registry registry.ci.openshift.org to PUBLIC_CONTAINER_REGISTRIES to bypass auth registry validation via validations.ParsePublicRegistries

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fiblan
Once this PR has been reviewed and has the lgtm label, please assign gamli75 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @fiblan. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[CrystalChun]

Hey @fiblan, thanks for creating a PR! I'm not familiar with OKD, but does it always allow pulling from registry.ci.openshift.org without credentials?

If not, it might not be best to have this as a default for others who use the podman configmap for OKD. Perhaps creating a PR to add documentation about OKD might be more preferable?

[fiblan]

Hey @CrystalChun thank you for the request for clarification! I confirm that during the installation phase, access to registry.ci.openshift.org is allowed without credentials since OKD releases are public. Moreover, the modification I proposed in this PR specifically refers to the deploy/podman/okd-configmap.yml. Without this change, the assisted installer will not let you proceed because it requires credentials for the registry, which are not necessary. Therefore, setting the config map for OKD to a public registry (registry.ci.openshift.org) ensures it works perfectly.

[CrystalChun]

/ok-to-test
Thanks for the explanation!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.28%. Comparing base (fdf233a) to head (bbb8d51).
Report is 326 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6344   +/-   ##
=======================================
  Coverage   68.27%   68.28%           
=======================================
  Files         241      241           
  Lines       35873    35874    +1     
=======================================
+ Hits        24493    24497    +4     
+ Misses       9215     9214    -1     
+ Partials     2165     2163    -2     

see 4 files with indirect coverage changes

[openshift-ci]

@fiblan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-verify-generated-code	bbb8d51	link	true	/test edge-verify-generated-code
ci/prow/e2e-agent-compact-ipv4	bbb8d51	link	true	/test e2e-agent-compact-ipv4
ci/prow/edge-e2e-metal-assisted-odf-4-16	bbb8d51	link	true	/test edge-e2e-metal-assisted-odf-4-16
ci/prow/edge-e2e-metal-assisted-cnv-4-16	bbb8d51	link	true	/test edge-e2e-metal-assisted-cnv-4-16
ci/prow/edge-e2e-metal-assisted-mtv-4-17	bbb8d51	link	true	/test edge-e2e-metal-assisted-mtv-4-17
ci/prow/edge-e2e-metal-assisted-osc-sno-4-17	bbb8d51	link	true	/test edge-e2e-metal-assisted-osc-sno-4-17
ci/prow/edge-e2e-metal-assisted-osc-4-17	bbb8d51	link	true	/test edge-e2e-metal-assisted-osc-4-17

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[danmanor]

@fiblan is this still relevant ? if so can you provide some context please ?