Skip to content

[cloud_hotfix_releases] MGMT-17558: Allow installation on iSCSI volume - #6222

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:cloud_hotfix_releasesfrom
openshift-cherrypick-robot:cherry-pick-6218-to-cloud_hotfix_releases
Apr 19, 2024
Merged

[cloud_hotfix_releases] MGMT-17558: Allow installation on iSCSI volume#6222
openshift-merge-bot[bot] merged 1 commit into
openshift:cloud_hotfix_releasesfrom
openshift-cherrypick-robot:cherry-pick-6218-to-cloud_hotfix_releases

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 18, 2024

Copy link
Copy Markdown

This is an automated cherry-pick of #6218

/assign gamli75

@adriengentil openshift-cherrypick-robot
MGMT-17558: Allow installation on iSCSI volume
7738c1a 
Open installation of OCP on iSCSI boot volume to all platforms.

Remove `ip=ibft` from the kernel arguments as it prevent proper network
configuration when several NICs are in use. RHCOS team recommend to
leave DHCP configuration.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 18, 2024
Merged
@openshift-ci-robot

openshift-ci-robot commented Apr 18, 2024 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-17558

Details

In response to this:

This is an automated cherry-pick of #6218

/assign gamli75

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 18, 2024
@openshift-ci
openshift-ci Bot requested review from carbonin and eliorerz April 18, 2024 19:15
@codecov

codecov Bot commented Apr 18, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.21%. Comparing base (ef0c961) to head (7738c1a).
Report is 991 commits behind head on cloud_hotfix_releases.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##           cloud_hotfix_releases    #6222      +/-   ##
=========================================================
+ Coverage                  66.66%   68.21%   +1.55%     
=========================================================
  Files                        197      242      +45     
  Lines                      27526    35873    +8347     
=========================================================
+ Hits                       18350    24472    +6122     
- Misses                      7531     9274    +1743     
- Partials                    1645     2127     +482
Files Coverage Δ
internal/hardware/validator.go 77.17% <100.00%> (+2.06%) ⬆️
internal/host/hostcommands/install_cmd.go 84.45% <100.00%> (+0.95%) ⬆️
internal/host/validator.go 81.73% <100.00%> (+3.16%) ⬆️

... and 157 files with indirect coverage changes

@openshift-ci

openshift-ci Bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@openshift-ci

openshift-ci Bot commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@gamli75

gamli75 commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Apr 19, 2024 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@gamli75: This pull request references MGMT-17558 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 19, 2024
@openshift-merge-bot
openshift-merge-bot Bot merged commit 3d50ab0 into openshift:cloud_hotfix_releases Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gamli75 gamli75 gamli75 approved these changes
@carbonin carbonin Awaiting requested review from carbonin
@eliorerz eliorerz Awaiting requested review from eliorerz

Assignees

@gamli75 gamli75

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @openshift-ci-robot @gamli75 @adriengentil