Skip to content

[cloud_hotfix_releases] MGMT-17515: Fix the CPU architecture query for in GetReleaseImage to having the necessary CPU architecture in the list and the list must be of size one to exclude multi architecture release images - #6210

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:cloud_hotfix_releasesfrom
openshift-cherrypick-robot:cherry-pick-6186-to-cloud_hotfix_releases
Apr 18, 2024

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #6186

/assign danmanor

…Release Syncer - if there are release images already in the DB, continue using the stale data instead of failing / truncating the table (openshift#6145)
@openshift-ci-robot

openshift-ci-robot commented Apr 18, 2024 •

Copy link
Copy Markdown

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-17515

Details

In response to this:

This is an automated cherry-pick of #6186

/assign danmanor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 18, 2024
@openshift-ci
openshift-ci Bot requested review from omertuc and ori-amizur April 18, 2024 10:43
@danmanor

Copy link
Copy Markdown
Contributor

/cc @eifrach @rccrdpccl @adriengentil

@codecov

codecov Bot commented Apr 18, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.29%. Comparing base (ef0c961) to head (12779b6).
Report is 990 commits behind head on cloud_hotfix_releases.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##           cloud_hotfix_releases    #6210      +/-   ##
=========================================================
+ Coverage                  66.66%   68.29%   +1.62%     
=========================================================
  Files                        197      242      +45     
  Lines                      27526    35945    +8419     
=========================================================
+ Hits                       18350    24547    +6197     
- Misses                      7531     9273    +1742     
- Partials                    1645     2125     +480     
Files Coverage Δ
internal/versions/rest_api_versions.go 71.02% <100.00%> (ø)

... and 159 files with indirect coverage changes

@danmanor

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 18, 2024
@openshift-ci-robot

openshift-ci-robot commented Apr 18, 2024 •

Copy link
Copy Markdown

@danmanor: This pull request references MGMT-17515 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danmanor

Copy link
Copy Markdown
Contributor

/lgtm

@danmanor

Copy link
Copy Markdown
Contributor

/approve

@danmanor

Copy link
Copy Markdown
Contributor

/refresh-status

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@openshift-ci

openshift-ci Bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@openshift-ci

openshift-ci Bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 85333c2 into openshift:cloud_hotfix_releases Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants