Skip to content

[cloud_hotfix_releases] MGMT-17513: Change the latest release image retrieved in GetReleaseImage using major.minor OpenShift version to latest non-beta release image if exists, or latest beta release image otherwise - #6205

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:cloud_hotfix_releasesfrom
openshift-cherrypick-robot:cherry-pick-6185-to-cloud_hotfix_releases
Apr 18, 2024

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #6185

/assign danmanor

…age using major.minor OpenShift version to latest non-beta release image if exists, or latest beta release image otherwise
@openshift-ci-robot

openshift-ci-robot commented Apr 17, 2024 •

Copy link
Copy Markdown

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-17513

Details

In response to this:

This is an automated cherry-pick of #6185

/assign danmanor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 17, 2024
@openshift-ci
openshift-ci Bot requested review from eifrach and rccrdpccl April 17, 2024 21:27
@codecov

codecov Bot commented Apr 17, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.26%. Comparing base (ef0c961) to head (0159ed5).
Report is 988 commits behind head on cloud_hotfix_releases.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##           cloud_hotfix_releases    #6205      +/-   ##
=========================================================
+ Coverage                  66.66%   68.26%   +1.59%     
=========================================================
  Files                        197      242      +45     
  Lines                      27526    36021    +8495     
=========================================================
+ Hits                       18350    24588    +6238     
- Misses                      7531     9307    +1776     
- Partials                    1645     2126     +481     
Files Coverage Δ
internal/versions/rest_api_versions.go 73.04% <100.00%> (ø)

... and 159 files with indirect coverage changes

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@openshift-ci

openshift-ci Bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@gamli75

gamli75 commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

/label jira/valid-reference

@gamli75

gamli75 commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

/label ?

@openshift-ci

openshift-ci Bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

@gamli75: The label(s) /label ? cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danmanor

Copy link
Copy Markdown
Contributor

hold

@danmanor

Copy link
Copy Markdown
Contributor

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@danmanor

Copy link
Copy Markdown
Contributor

/unhold

@danmanor

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 18, 2024
@openshift-ci-robot

openshift-ci-robot commented Apr 18, 2024 •

Copy link
Copy Markdown

@danmanor: This pull request references MGMT-17513 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@openshift-ci

openshift-ci Bot commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 4053a74 into openshift:cloud_hotfix_releases Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants