Skip to content

[cloud_hotfix_releases] MGMT-17438: bugfix, make sure ODF and LVM requirements do not change if MCE not selected - #6160

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:cloud_hotfix_releasesfrom
openshift-cherrypick-robot:cherry-pick-6150-to-cloud_hotfix_releases
Apr 9, 2024
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:cloud_hotfix_releasesfrom
openshift-cherrypick-robot:cherry-pick-6150-to-cloud_hotfix_releases

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown

This is an automated cherry-pick of #6150

/assign rccrdpccl

…if MCE is not selected

Signed-off-by: Riccardo Piccoli <rpiccoli@redhat.com>
@openshift-ci-robot

openshift-ci-robot commented Apr 8, 2024 •

Copy link
Copy Markdown

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-17438

Details

In response to this:

This is an automated cherry-pick of #6150

/assign rccrdpccl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 8, 2024
@openshift-ci
openshift-ci Bot requested review from avishayt and ori-amizur April 8, 2024 09:35
@rccrdpccl

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2024
@openshift-ci

openshift-ci Bot commented Apr 8, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@codecov

codecov Bot commented Apr 8, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 68.32%. Comparing base (ef0c961) to head (cae00a0).
Report is 985 commits behind head on cloud_hotfix_releases.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##           cloud_hotfix_releases    #6160      +/-   ##
=========================================================
+ Coverage                  66.66%   68.32%   +1.66%     
=========================================================
  Files                        197      242      +45     
  Lines                      27526    35798    +8272     
=========================================================
+ Hits                       18350    24459    +6109     
- Misses                      7531     9214    +1683     
- Partials                    1645     2125     +480     
Files Coverage Δ
internal/operators/cnv/cnv_operator.go 79.65% <100.00%> (-1.10%) ⬇️
internal/operators/manager.go 78.07% <100.00%> (-3.79%) ⬇️
internal/operators/mce/mce_operator.go 71.55% <100.00%> (ø)
internal/operators/odf/validations.go 97.61% <100.00%> (-0.26%) ⬇️
internal/operators/lso/ls_operator.go 9.52% <0.00%> (-1.91%) ⬇️
internal/operators/odf/odf_operator.go 63.33% <81.81%> (-0.77%) ⬇️
internal/operators/lvm/lvm_operator.go 76.63% <42.85%> (-1.42%) ⬇️

... and 153 files with indirect coverage changes

@rccrdpccl

Copy link
Copy Markdown
Contributor

/retest

@rccrdpccl

Copy link
Copy Markdown
Contributor

/override ci/prow/subsystem-aws

cluster claim not available :(

@openshift-ci

openshift-ci Bot commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

@rccrdpccl: Overrode contexts on behalf of rccrdpccl: ci/prow/subsystem-aws

Details

In response to this:

/override ci/prow/subsystem-aws

cluster claim not available :(

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci

openshift-ci Bot commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rccrdpccl

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 9, 2024
@openshift-ci-robot

openshift-ci-robot commented Apr 9, 2024 •

Copy link
Copy Markdown

@rccrdpccl: This pull request references MGMT-17438 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
openshift-merge-bot Bot merged commit a3cc65b into openshift:cloud_hotfix_releases Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants