Skip to content

Conversation

@ori-amizur
Copy link
Contributor

@ori-amizur ori-amizur commented Jun 8, 2021

This PR openshift/machine-config-operator#2564 moved the tunnel offloading patch to base and not just vsphere platform

Description

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

Please, select one or more if needed:

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • VMWARE cluster installation
  • No tests needed

It's recommended to take a few extra minutes to provide more information about
how this code was tested. Here are some questions that may be worth answering:

  • Should this PR be tested by the reviewer? No
  • Is this PR relying on CI for an e2e test run? No
  • Should this PR be tested in a specific environment? Already tested
  • Any logs, screenshots, etc that can help with the review process?

Assignees

Please, add one or two reviewers that could help review this PR.

/assign @ronniel1
/assign @yevgeny-shnaidman

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • Reviewers have been listed
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ori-amizur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from mkowalski and slaviered June 8, 2021 18:16
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2021
…done by OCP

This PR openshift/machine-config-operator#2564 moved the tunnel offloading patch to base and not just vsphere platform
@ori-amizur
Copy link
Contributor Author

/retest

@mkowalski
Copy link
Contributor

/uncc @mkowalski

@openshift-ci openshift-ci bot removed the request for review from mkowalski June 9, 2021 09:30
@tsorya
Copy link
Contributor

tsorya commented Jun 10, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 86ad71a into openshift:master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants