Skip to content

Conversation

@ropatil010
Copy link

@ropatil010 ropatil010 commented Nov 10, 2025

Hi Team,

Can you PTAL for the fix?

Task: https://issues.redhat.com/browse/CNTRLPLANE-1909
Issue: Doesn't show the allowed ranges in the error message.
Fix: Show the allowed ranges in the error message.

@openshift-ci openshift-ci bot requested review from ibihim and liouk November 10, 2025 14:54
@ropatil010
Copy link
Author

/test unit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ropatil010
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ropatil010 ropatil010 changed the title Improve error messages for group validation to show allowed ranges Implement runAsGroup validation check Nov 11, 2025
@ropatil010
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2025
@ropatil010
Copy link
Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2025
@ropatil010
Copy link
Author

/assign @haircommander

@ropatil010
Copy link
Author

/assign @tchap

@tchap tchap removed their assignment Nov 11, 2025
@ropatil010 ropatil010 changed the title Implement runAsGroup validation check [WIP] Implement runAsGroup validation check Nov 11, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2025
@ropatil010 ropatil010 changed the title [WIP] Implement runAsGroup validation check Implement runAsGroup validation check Nov 13, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2025

@ropatil010: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ropatil010
Copy link
Author

This PR depends on openshift/api#2580

The vendor directory has been manually updated to include the API types from #2580 to enable implementation and testing. Once #2580 merges, I will:
- Update go.mod to reference the merged version
- Remove deps.diff
- Clean up vendor directory
The implementation is complete and tested, pending upstream API merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants