Skip to content

Conversation

@csrwng
Copy link
Contributor

@csrwng csrwng commented Jul 1, 2021

Follow up to #940
Adds enum validation per field so that External is not a valid choice for InfraTopology

@openshift-ci openshift-ci bot requested review from deads2k and smarterclayton July 1, 2021 20:44
@csrwng
Copy link
Contributor Author

csrwng commented Jul 1, 2021

/assign @bparees

@bparees
Copy link
Contributor

bparees commented Jul 1, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit 46e2fe0 into openshift:master Jul 1, 2021
@csrwng csrwng deleted the limit_external_to_cp branch November 1, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants