Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #864

/assign staebler

Add a new field resourceTags to `.status.aws` of the
infrastructure.config.openshift.io type. Tags included
in the resourceTags field will be applied to new resources
created for the cluster.

https://issues.redhat.com/browse/CORS-1657
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Bugzilla bug 1950113 has been cloned as Bugzilla bug 1954152. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1954152: config: add aws usertags to infrastructure

Details

In response to this:

[release-4.7] Bug 1950113: config: add aws usertags to infrastructure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.7] Bug 1950113: config: add aws usertags to infrastructure [release-4.7] Bug 1954152: config: add aws usertags to infrastructure Apr 27, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Apr 27, 2021
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1954152, which is invalid:

  • expected dependent Bugzilla bug 1950113 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.7] Bug 1954152: config: add aws usertags to infrastructure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@staebler
Copy link
Contributor

/test verify-client-go

@bparees
Copy link
Contributor

bparees commented Apr 28, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 28, 2021
@openshift-ci-robot
Copy link

@bparees: This pull request references Bugzilla bug 1954152, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1950113 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1950113 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 28, 2021
@bparees
Copy link
Contributor

bparees commented Apr 28, 2021

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 28, 2021
@wking
Copy link
Member

wking commented Apr 28, 2021

verify-client-go:

INFO[2021-04-28T15:32:26Z] + mv ./vendor/k8s.io/code-generator/generate-groups.sh.orig ./vendor/k8s.io/code-generator/generate-groups.sh 
INFO[2021-04-28T15:32:26Z] apiserver/clientset/versioned/typed/apiserver/v1/apirequestcount.go:9:2: cannot find package "." in: 
INFO[2021-04-28T15:32:26Z] 	/go/src/github.com/openshift/client-go/vendor/github.com/openshift/api/apiserver/v1 
INFO[2021-04-28T15:32:26Z] cloudnetwork/clientset/versioned/typed/cloudnetwork/v1/cloudprivateipconfig.go:9:2: cannot find package "." in: 
INFO[2021-04-28T15:32:26Z] 	/go/src/github.com/openshift/client-go/vendor/github.com/openshift/api/cloudnetwork/v1 
INFO[2021-04-28T15:32:26Z] {"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2021-04-28T15:32:18Z"} 

Is that a Go version thing? I feel like I remember something about . package errors out of a recent Go bump...

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@staebler
Copy link
Contributor

/test verify-client-go

@openshift-merge-robot openshift-merge-robot merged commit a838993 into openshift:release-4.7 Apr 28, 2021
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1954152 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.7] Bug 1954152: config: add aws usertags to infrastructure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frobware added a commit to frobware/cluster-ingress-operator that referenced this pull request Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants