route: Define the ingress-to-route controller name #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Contributor
|
/lgtm |
This commit implements NE-574. https://issues.redhat.com/browse/NE-574 * route/v1/types.go (IngressToRouteIngressClassControllerName): New const. Define the name of the ingress-to-route controller. This name can be used for the spec.controller field of ingressclasses.
Miciah
force-pushed
the
NE-574-route-define-the-ingress-to-route-controller-name
branch
from
8db1461 to
abd04f1
Compare
Contributor
|
/lgtm |
Contributor
|
This change looks plausible, but the enhancement openshift/enhancements#697 needs to merge first with agreement to the migration path before we merge the API change itself. |
Contributor
|
/approve |
openshift-ci-robot
added
the
approved
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements NE-574.
route/v1/types.go(IngressToRouteIngressClassControllerName): New const. Define the name of the ingress-to-route controller. This name can be used for thespec.controllerfield of ingressclasses.