re-align selflink to kube #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soltysh
approved these changes
Dec 16, 2020
Contributor
soltysh
left a comment
soltysh
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/hold
until 4.8
openshift-ci-robot
added
the
do-not-merge/hold
This reverts commit 53e462e.
deads2k
force-pushed
the
remove-self-link
branch
from
7ca30a9 to
5f65a8c
Compare
openshift-ci-robot
added
approved
Contributor
Author
|
/hold cancel There may be a consideration of re-disabling this, but let's see how much more we can push to change with some advance notice. These are gone by default in kube. |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverts #825 to realign to kubernetes.