Skip to content

Conversation

@rkukura
Copy link

@rkukura rkukura commented Nov 25, 2020

This partially implements phase 1 of openshift/enhancements#482 and
does not change behavior. Initially, all API CRD manifests are
included in the single-node-developer cluster profile. Follow-on PRs
may exclude any of these that are not needed in the profile.

This partially implements phase 1 of openshift/enhancements#482 and
does not change behavior. Initially, all API CRD manifests are
included in the single-node-developer cluster profile. Follow-on PRs
may exclude any of these that are not needed in the profile.
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 25, 2020
@openshift-ci-robot
Copy link

Hi @rkukura. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cfergeau
Copy link

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2020
cfergeau added a commit to cfergeau/cluster-dns-operator that referenced this pull request Nov 26, 2020
This partially implements phase 1 of https://github.com/openshift/enhancements#482
and does not change behavior. Initially, all cluster-dns-operator CRD
manifests are included in the single-node-developer cluster profile.
Follow-on PRs may exclude any of these that are not needed in the
profile.

manifests/0000_70_dns-operator_00-custom-resource-definition.yaml will
need to be updated once openshift/api#792 is
merged.
@sttts
Copy link
Contributor

sttts commented Nov 30, 2020

This implements the annotation described in the approved enhancement.

/lgtm
/approve

@rkukura note, that you have to bump a large number of operators to pick these changes up. The api repo alone does not ship these changes.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rkukura, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 30, 2020
@sttts
Copy link
Contributor

sttts commented Nov 30, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit 19e3831 into openshift:master Nov 30, 2020
@rkukura rkukura deleted the crc_profile branch November 30, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants