Skip to content

Bug 1877693: dnsrecords specify recordTTL as 30 but the value is null in AWS Route 53 #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Nov 17, 2020
Merged

Bug 1877693: dnsrecords specify recordTTL as 30 but the value is null in AWS Route 53 #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion operatoringress/v1/0000_50_dns-record.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ spec:
minLength: 1
recordTTL:
description: recordTTL is the record TTL in seconds. If zero, the default
is 30.
is 30. RecordTTL will not be used in AWS regions Alias targets, but
will be used in CNAME targets, per AWS API contract.
type: integer
format: int64
minimum: 0
Expand Down
6 changes: 4 additions & 2 deletions operatoringress/v1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ type DNSRecordSpec struct {
// +required
RecordType DNSRecordType `json:"recordType"`
// recordTTL is the record TTL in seconds. If zero, the default is 30.
// RecordTTL will not be used in AWS regions Alias targets, but
// will be used in CNAME targets, per AWS API contract.
//
// +kubebuilder:validation:Required
// +kubebuilder:validation:Minimum=0
Expand Down Expand Up @@ -103,10 +105,10 @@ type DNSZoneCondition struct {
type DNSRecordType string

const (
// CNAME is an RFC 1035 CNAME record.
// CNAMERecordType is an RFC 1035 CNAME record.
CNAMERecordType DNSRecordType = "CNAME"

// CNAME is an RFC 1035 A record.
// ARecordType is an RFC 1035 A record.
ARecordType DNSRecordType = "A"
)

Expand Down
2 changes: 1 addition & 1 deletion operatoringress/v1/zz_generated.swagger_doc_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.