fixes IngressControllerCaptureHTTPCookie#776
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Nov 2, 2020
Merged
fixes IngressControllerCaptureHTTPCookie#776openshift-merge-robot merged 2 commits intoopenshift:masterfrom
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
as per https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20190325-unions.md#go-tags all fields inside a union must be optional. this PR moves all optional fields to a new struct IngressControllerCaptureHTTPCookieUnion and leaves the required in the top level struct
Contributor
Author
|
/assign @sttts |
p0lyn0mial
force-pushed
the
fix-ingress-controller-capture-union
branch
from
7647134 to
513dd66
Compare
p0lyn0mial
commented
Nov 2, 2020
| // captured. | ||
| // +union | ||
| type IngressControllerCaptureHTTPCookie struct { | ||
| IngressControllerCaptureHTTPCookieUnion `json:",inline"` |
Contributor
Author
There was a problem hiding this comment.
callers should start using IngressControllerCaptureHTTPCookieUnion instead
Contributor
Author
There was a problem hiding this comment.
new union types should be directly embedded to IngressControllerCaptureHTTPCookie
Contributor
|
/approve /hold to give @openshift/sig-network-edge some time to review |
openshift-ci-robot
added
do-not-merge/hold
p0lyn0mial
force-pushed
the
fix-ingress-controller-capture-union
branch
from
513dd66 to
64833fe
Compare
Contributor
|
Thanks! |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, p0lyn0mial, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
candita
added a commit
to candita/cluster-ingress-operator
that referenced
this pull request
Nov 18, 2020
… in AWS Route 53, also fix unit test issues introduced in openshift/api#776
candita
added a commit
to candita/cluster-ingress-operator
that referenced
this pull request
Nov 18, 2020
… in AWS Route 53, also bump version and fix unit test issues introduced in openshift/api#776
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as per https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20190325-unions.md#go-tags all fields inside a union must be optional.
this PR moves all optional fields to a new struct
IngressControllerCaptureHTTPCookieUnionand leaves the required in the top level struct