NE-407: operator/ingress: Add ELB connection idle timeout #730

Miciah · 2020-09-01T03:43:16Z

operator/v1/types_ingress.go (AWSClassicLoadBalancerParameters): Add ConnectionIdleTimeoutSeconds field.
operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml:
operator/v1/zz_generated.swagger_doc_generated.go: Regenerate.

openshift-ci-robot · 2020-09-01T03:43:34Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Miciah
To complete the pull request process, please assign sjenning
You can assign the PR to them by writing /assign @sjenning in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-12-01T03:33:32Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2020-12-31T05:24:37Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2021-01-30T07:15:44Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot · 2021-01-30T07:15:58Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2022-04-06T23:11:10Z

/reopen
/remove-lifecycle rotten

openshift-ci · 2022-04-06T23:11:35Z

@Miciah: Reopened this PR.

Details

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2022-04-06T23:12:18Z

Rebased.

Miciah · 2022-04-06T23:15:00Z

Updated to match the current version of the enhancement PR.

JoelSpeed · 2022-04-12T08:19:57Z

operator/v1/types_ingress.go

+	// +kubebuilder:validation:Optional
+	// +kubebuilder:validation:Format=duration
+	// +optional
+	ConnectionIdleTimeout *metav1.Duration `json:"connectionIdleTimeout"`


Does this need an omitempty?

JoelSpeed

/lgtm

Miciah · 2022-04-12T14:24:27Z

Trying to pull registry.build02.ci.openshift.org/ci/managed-clonerefs@sha256:d4f56ce76ea8cacb4f39b1cf7abaf2de8ac64274759bb94dc6341ffbc3f297f1...
error: error creating buildah builder: initializing source docker://registry.build02.ci.openshift.org/ci/managed-clonerefs@sha256:d4f56ce76ea8cacb4f39b1cf7abaf2de8ac64274759bb94dc6341ffbc3f297f1: pinging container registry registry.build02.ci.openshift.org: Get "https://registry.build02.ci.openshift.org/v2/": dial tcp: i/o timeout
error while getting build logs, could not retrieve build pod ci-op-pg9kfbhj/src-build : pod "src-build" not found�[36mINFO�[0m[2022-04-12T13:23:50Z] Ran for 1m18s

/test verify-deps

jldohmann · 2022-04-23T00:12:14Z

/label docs-approved

quarterpin · 2022-04-26T04:44:12Z

/label qe-approved

CFields651 · 2022-04-29T20:46:53Z

/label px-approved

deads2k · 2022-04-29T21:57:58Z

/approve

/hold

hold pending link to why we cannot use non-pointer.

* operator/v1/types_ingress.go (AWSClassicLoadBalancerParameters): Add ConnectionIdleTimeout field. * operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml: * operator/v1/zz_generated.swagger_doc_generated.go: Regenerate.

deads2k · 2022-04-29T22:07:39Z

/lgtm
/hold cancel

openshift-ci · 2022-04-29T22:07:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-04-29T22:18:05Z

@Miciah: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot requested review from adambkaplan and eparis September 1, 2020 03:43

Miciah force-pushed the operator-slash-ingress-add-ELB-connection-idle-timeout branch from 555200e to 65ef420 Compare September 1, 2020 22:49

openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 1, 2020

openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 31, 2020

openshift-ci-robot closed this Jan 30, 2021

openshift-ci bot reopened this Apr 6, 2022

openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 6, 2022

Miciah force-pushed the operator-slash-ingress-add-ELB-connection-idle-timeout branch from 65ef420 to 5cc1aaf Compare April 6, 2022 23:12

Miciah force-pushed the operator-slash-ingress-add-ELB-connection-idle-timeout branch from 5cc1aaf to 0d2b868 Compare April 6, 2022 23:14

JoelSpeed reviewed Apr 12, 2022

View reviewed changes

Miciah force-pushed the operator-slash-ingress-add-ELB-connection-idle-timeout branch 2 times, most recently from 05c0dbc to 6fa7075 Compare April 12, 2022 13:21

JoelSpeed reviewed Apr 12, 2022

View reviewed changes

openshift-ci bot assigned JoelSpeed Apr 12, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2022

Miciah changed the title ~~operator/ingress: Add ELB connection idle timeout~~ NE-407: operator/ingress: Add ELB connection idle timeout Apr 13, 2022

Miciah mentioned this pull request Apr 22, 2022

NE-406: ingress: Add aws-elb-idle-timeout enhancement openshift/enhancements#461

Merged

2 tasks

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Apr 23, 2022

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 26, 2022

openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Apr 29, 2022

openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 29, 2022

operator/ingress: Add ELB connection idle timeout

82a1f62

* operator/v1/types_ingress.go (AWSClassicLoadBalancerParameters): Add ConnectionIdleTimeout field. * operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml: * operator/v1/zz_generated.swagger_doc_generated.go: Regenerate.

Miciah force-pushed the operator-slash-ingress-add-ELB-connection-idle-timeout branch from 6fa7075 to 82a1f62 Compare April 29, 2022 22:07

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2022

openshift-ci bot assigned deads2k Apr 29, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2022

openshift-merge-robot merged commit b25f69a into openshift:master Apr 29, 2022

Miciah mentioned this pull request Apr 29, 2022

NE-408: Allow configuring ELB connection idle timeout openshift/cluster-ingress-operator#451

Merged

NE-407: operator/ingress: Add ELB connection idle timeout #730

NE-407: operator/ingress: Add ELB connection idle timeout #730

Uh oh!

Conversation

Miciah commented Sep 1, 2020

Uh oh!

openshift-ci-robot commented Sep 1, 2020

Uh oh!

openshift-bot commented Dec 1, 2020

Uh oh!

openshift-bot commented Dec 31, 2020

Uh oh!

openshift-bot commented Jan 30, 2021

Uh oh!

openshift-ci-robot commented Jan 30, 2021

Uh oh!

Miciah commented Apr 6, 2022

Uh oh!

openshift-ci bot commented Apr 6, 2022

Uh oh!

Miciah commented Apr 6, 2022

Uh oh!

Miciah commented Apr 6, 2022

Uh oh!

JoelSpeed Apr 12, 2022

Choose a reason for hiding this comment

Uh oh!

JoelSpeed left a comment

Choose a reason for hiding this comment

Uh oh!

Miciah commented Apr 12, 2022

Uh oh!

jldohmann commented Apr 23, 2022

Uh oh!

quarterpin commented Apr 26, 2022

Uh oh!

CFields651 commented Apr 29, 2022

Uh oh!

deads2k commented Apr 29, 2022

Uh oh!

deads2k commented Apr 29, 2022

Uh oh!

openshift-ci bot commented Apr 29, 2022

Uh oh!

openshift-ci bot commented Apr 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants