operator/ingress: Add parameters for empty requests #729
Conversation
openshift-ci-robot
added
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Miciah
force-pushed
the
operator-slash-ingress-add-parameters-for-empty-requests
branch
from
434d82f to
c343823
Compare
openshift-ci-robot
removed
the
needs-rebase
Miciah
force-pushed
the
operator-slash-ingress-add-parameters-for-empty-requests
branch
from
c343823 to
699bb3c
Compare
|
/refresh |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci-robot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci-robot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@Miciah: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
needs-rebase
Miciah
force-pushed
the
operator-slash-ingress-add-parameters-for-empty-requests
branch
from
699bb3c to
1330292
Compare
|
Rebased. |
openshift-ci
bot
removed
the
needs-rebase
Miciah
force-pushed
the
operator-slash-ingress-add-parameters-for-empty-requests
branch
from
1330292 to
ed6cc37
Compare
* operator/v1/types_ingress.go (IngressControllerSpec): Add HTTPEmptyRequestsPolicy field for configuring how the ingress controller should handle HTTP connections for which no request is received. (LoggingPolicy): New type. Specify whether an event should be logged. (LoggingPolicyLog, LoggingPolicyIgnore): New constants. (AccessLogging): Add LogEmptyRequests field using the new LoggingPolicy type. (HTTPEmptyRequestsPolicy): New type. Specify how HTTP connections for which no requests is received should be handled. (HTTPEmptyRequestsPolicyRespond, HTTPEmptyRequestsPolicyIgnore): New constants. * operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml: * operator/v1/zz_generated.swagger_doc_generated.go: Regenerate.
Miciah
force-pushed
the
operator-slash-ingress-add-parameters-for-empty-requests
branch
from
ed6cc37 to
69c7751
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, knobunc, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
6 participants
operator/v1/types_ingress.go(IngressControllerSpec): AddHTTPEmptyRequestsPolicyfield for configuring how the ingress controller should handle HTTP connections for which no request is received.(
LoggingPolicy): New type. Specify whether an event should be logged.(
LoggingPolicyLog,LoggingPolicyIgnore): New constants.(
AccessLogging): AddLogEmptyRequestsfield using the newLoggingPolicytype.(
HTTPEmptyRequestsPolicy): New type. Specify how HTTP connections for which no requests is received should be handled.(
HTTPEmptyRequestsPolicyRespond,HTTPEmptyRequestsPolicyIgnore): New constants.operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml:operator/v1/zz_generated.swagger_doc_generated.go: Regenerate.Related to openshift/enhancements#460.