Bug 1808118: Migrating imageregistry to extensions v1 #726
Conversation
Some of our types now inherit the Default directive. This directive is incompatible with v1beta1. This PR migrates imageregistry CRDs to v1 instead. The error we are seeing without this migration: "cannot set default values in apiextensions.k8s.io/v1beta1 CRDs, must use apiextensions.k8s.io/v1"
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@ricardomaraschini: This pull request references Bugzilla bug 1808118, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@ricardomaraschini: This pull request references Bugzilla bug 1808118, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @dmage I guess that would be it, I do recognize I don't fully understand the implications of such a change. |
|
I did attempt to create the resulting CRDs (with different names) in a cluster and it worked. |
imageregistry/v1/00-crd.yaml
Outdated
| listKind: ConfigList | ||
| plural: configs | ||
| singular: config | ||
| preserveUnknownFields: false |
There was a problem hiding this comment.
this is not needed anymore with v1
imageregistry/v1/00-crd.yaml
Outdated
| singular: config | ||
| preserveUnknownFields: false | ||
| subresources: | ||
| status: {} |
There was a problem hiding this comment.
subresources must go into the version slice.
imageregistry/v1/01-crd.yaml
Outdated
| format: int64 | ||
| preserveUnknownFields: false | ||
| subresources: | ||
| status: {} |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Removed preserveUnknownFields and moved subresource to inside versions slice.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ricardomaraschini, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@ricardomaraschini: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1808118 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
Some of our types now inherit the Default directive. This directive is incompatible with v1beta1. This PR migrates imageregistry CRDs to v1 instead. The error we are seeing without this migration:
cannot set default values in apiextensions.k8s.io/v1beta1 CRDs, must use apiextensions.k8s.io/v1Default directive was introduced through e9ece8d