Skip to content

Conversation

@ricardomaraschini
Copy link
Contributor

Logging has been deprecated in favour of LogLevel, therefore this field
is now optional and should so be updated on api accordingly.

Logging has been deprecated in favour of LogLevel, therefore this field
is now optional and should so be updated on api accordingly.
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 25, 2020
@openshift-ci-robot
Copy link

@ricardomaraschini: This pull request references Bugzilla bug 1808118, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1808118: Making logging parameter optional

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ricardomaraschini
To complete the pull request process, please assign eparis
You can assign the PR to them by writing /assign @eparis in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ricardomaraschini
Copy link
Contributor Author

ricardomaraschini commented Aug 25, 2020

/assign @dmage

Have no idea how I ended loosing this change on the original PR 👎 Could you remember me if this was removed on purpose? Before I assign someone else to review this I would like to have your OK.

#640 (review)

@dmage
Copy link
Contributor

dmage commented Aug 25, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2020
@ricardomaraschini
Copy link
Contributor Author

New PR for this #727

@openshift-ci-robot
Copy link

@ricardomaraschini: This pull request references Bugzilla bug 1808118. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1808118: Making logging parameter optional

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants