bug 1871890: add current profile annotations to CVO manifests

[deads2k]

This is matches openshift/enhancements#414 and doesn't change existing behavior

[openshift-ci-robot]

@deads2k: This pull request references Bugzilla bug 1871890, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

bug 1871890: add current profile annotations to CVO manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

This is matches openshift/enhancements#414...

Looks like that enhancement needs a reroll to mention the new profile name? Or are we not tracking profile names in a registry-like list? Do we want the enhancement PR to actually land before we land code changes implementing it?

I'm also ok linking the landed enhancement as motivation and not waiting on 414, if we want to go with the "don't bother maintaining a profile registry" approach.

[deads2k]

This is matches openshift/enhancements#414...

Looks like that enhancement needs a reroll to mention the new profile name? Or are we not tracking profile names in a registry-like list? Do we want the enhancement PR to actually land before we land code changes implementing it?

I'm also ok linking the landed enhancement as motivation and not waiting on 414, if we want to go with the "don't bother maintaining a profile registry" approach.

I don't see a reason to wait. We agreed to the format and to this particular name.

[wking]

I don't see a reason to wait. We agreed to the format and to this particular name.

So what's holding us up on landing the enhancement?

[soltysh]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [deads2k,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@deads2k: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/cluster-openshift-controller-manager-operator#171 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1871890 has not been moved to the MODIFIED state.

Details

In response to this:

bug 1871890: add current profile annotations to CVO manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.