config/v1/types_infrastructure: Default ports for apiServerInternalURL too #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L too We've declared the default ports for apiServerURL since afb690a (modified port details for APIServerURL, 2020-05-13, openshift#646). Echo that for apiServerInternalURL. We don't have to call this out explicitly, since the IANA URI scheme registry [1] links out to [2] for http and [3] for https, which have: If the port subcomponent is empty or not given, TCP port 80 (the reserved port for WWW services) is the default. and: All of the requirements listed above for the "http" scheme are also requirements for the "https" scheme, except that TCP port 443 is the default if the port subcomponent is empty or not given... respectively. But echoing those defaults locally doesn't hurt. Autogenerated bumps via: $ hack/update-swagger-docs.sh $ make update-codegen-crds [1]: https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml [2]: https://tools.ietf.org/html/rfc7230#section-2.7.1 [3]: https://tools.ietf.org/html/rfc7230#section-2.7.2
HTTP in apiServerInternalURL will cause kubelets to stop communicating to the kube-apiserver. The client won't send bearer tokens, so the kubelets wouldn't start. HTTP in apiServerURL... might work. But seems unwise, and requiring 'http' here keeps us consistent. Autogenerated bumps via: $ hack/update-swagger-docs.sh $ make update-codegen-crds
Member
Author
Contributor
|
This change matches the current reality.
|
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've declared the default ports for apiServerURL since afb690a (#646). Echo that for
apiServerInternalURL. We don't have to call this out explicitly, since the IANA URI scheme registry links out to RFC 7230 for http and https, which have:and:
respectively. But echoing those defaults locally doesn't hurt.
Autogenerated bumps via: