Skip to content

port details for APIServerURL #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 4 commits into from
Jul 14, 2020
Merged

port details for APIServerURL #646

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
afb690a
modified port details for APIServerURL
a7vicky May 13, 2020
c8bc953
udated api doc with CRD
May 31, 2020
c634178
udated api doc with CRD
a7vicky Jun 2, 2020
036dcf0
updated apiServerURL details in swagger doc
a7vicky Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config/v1/0000_10_config-operator_01_infrastructure.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ spec:
type: string
apiServerURL:
description: apiServerURL is a valid URI with scheme(http/https), address
and port. apiServerURL can be used by components like the web console
and port and optionally a port (defaulting to 80 for http and 443

@sttts sttts Jun 2, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one "and port"

for https). apiServerURL can be used by components like the web console
to tell users where to find the Kubernetes API.
type: string
etcdDiscoveryDomain:
Expand Down
2 changes: 1 addition & 1 deletion config/v1/types_infrastructure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ type InfrastructureStatus struct {
EtcdDiscoveryDomain string `json:"etcdDiscoveryDomain"`

// apiServerURL is a valid URI with scheme(http/https), address and
// port. apiServerURL can be used by components like the web console
// port and optionally a port (defaulting to 80 for http and 443 for https). apiServerURL can be used by components like the web console
// to tell users where to find the Kubernetes API.
APIServerURL string `json:"apiServerURL"`

Expand Down