Skip to content

vsphere ipi: align with baremetal and remove nodednsip #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcpowermac wants to merge 1 commit into from
Closed

vsphere ipi: align with baremetal and remove nodednsip #630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions config/v1/0000_10_config-operator_01_infrastructure.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,12 +384,3 @@ spec:
default ingress controller. The IP is a suitable target of
a wildcard DNS record used to resolve default route host names.
type: string
nodeDNSIP:
description: nodeDNSIP is the IP address for the internal DNS
used by the nodes. Unlike the one managed by the DNS operator,
`NodeDNSIP` provides name resolution for the nodes themselves.
There is no DNS-as-a-service for vSphere deployments. In order
to minimize necessary changes to the datacenter DNS, a DNS
service is hosted as a static pod to serve those hostnames
to the nodes in the cluster.
type: string
8 changes: 0 additions & 8 deletions config/v1/types_infrastructure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,14 +378,6 @@ type VSpherePlatformStatus struct {
// ingressIP is an external IP which routes to the default ingress controller.
// The IP is a suitable target of a wildcard DNS record used to resolve default route host names.
IngressIP string `json:"ingressIP,omitempty"`

// nodeDNSIP is the IP address for the internal DNS used by the
// nodes. Unlike the one managed by the DNS operator, `NodeDNSIP`
// provides name resolution for the nodes themselves. There is no DNS-as-a-service for
// vSphere deployments. In order to minimize necessary changes to the
// datacenter DNS, a DNS service is hosted as a static pod to serve those hostnames
// to the nodes in the cluster.
NodeDNSIP string `json:"nodeDNSIP,omitempty"`
Copy link
Contributor

@soltysh soltysh May 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't remove fields from GA API, you can deprecate and only then remove. Even if this was not a used. API is a contract with a user, we can't break it.

}

// IBMCloudPlatformSpec holds the desired state of the IBMCloud infrastructure provider.
Expand Down
1 change: 0 additions & 1 deletion config/v1/zz_generated.swagger_doc_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.