Skip to content

adds a new ManagingOAuthAPIServer field to authentication's operator status field#567

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
p0lyn0mial:cao-managing-oauth-api-server-field
Jan 15, 2020
Merged

adds a new ManagingOAuthAPIServer field to authentication's operator status field#567
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
p0lyn0mial:cao-managing-oauth-api-server-field

Conversation

@p0lyn0mial
Copy link
Contributor

the new field indicates whether CAS is managing OAuth related APIs. Setting this field to true will cause OAS-O to step down

required to implement openshift/cluster-openshift-apiserver-operator#294

@p0lyn0mial
Copy link
Contributor Author

/assign @deads2k

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 15, 2020
…status field

the new field indicates whether CAS is managing OAuth related APIs. Setting this field to true will cause OAS-O to step down
@p0lyn0mial p0lyn0mial force-pushed the cao-managing-oauth-api-server-field branch from e73e5d3 to b464797 Compare January 15, 2020 10:47
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2020
@p0lyn0mial p0lyn0mial force-pushed the cao-managing-oauth-api-server-field branch from 398e1d4 to 572ec0c Compare January 15, 2020 11:27
@deads2k
Copy link
Contributor

deads2k commented Jan 15, 2020

/lgtm
/cherrypick release-4.3

@openshift-cherrypick-robot

@deads2k: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

Details

In response to this:

/lgtm
/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2020
@openshift-merge-robot openshift-merge-robot merged commit f472aa2 into openshift:master Jan 15, 2020
@openshift-cherrypick-robot

@deads2k: #567 failed to apply on top of branch "release-4.3":

Applying: generated
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
A	go.mod
A	go.sum
M	operator/v1/zz_generated.swagger_doc_generated.go
Falling back to patching base and 3-way merge...
Auto-merging vendor/k8s.io/code-generator/go.sum
CONFLICT (content): Merge conflict in vendor/k8s.io/code-generator/go.sum
Auto-merging operator/v1/zz_generated.swagger_doc_generated.go
CONFLICT (modify/delete): go.mod deleted in HEAD and modified in generated. Version generated of go.mod left in tree.
Patch failed at 0002 generated

Details

In response to this:

/lgtm
/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants