Skip to content

Conversation

@adambkaplan
Copy link
Contributor

Add omitempty tag so empty values are not validated by the regex.

Add `omitempty` tag so empty values are not validated by the regex.
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 10, 2020
@adambkaplan
Copy link
Contributor Author

/assign @deads2k

fyi @sttts seems that the verify test isn't picking up mismatches between the godoc and the generated CRDs.

@adambkaplan
Copy link
Contributor Author

Note - the RolloutStrategy field is new and has not been installed on any OpenShift cluster yet.

@deads2k
Copy link
Contributor

deads2k commented Jan 10, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit 61108cb into openshift:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants