NE-150: operator/ingress: Add observedGeneration#472
Conversation
https://jira.coreos.com/projects/NE/issues/NE-150 * operator/v1/types_ingress.go (IngressControllerStatus): Add ObservedGeneration field. * operator/v1/zz_generated.swagger_doc_generated.go: Regenerate.
openshift-ci-robot
added
the
size/XS
|
Hm, shouldn't CRDs have also been regenerated? (#470) |
Sorry, I'll update. |
|
Maybe I'm misunderstanding, but it looks like operator/v1 CRDs don't get generated, only operator/v1alpha1 and other API groups: https://github.com/openshift/api/blob/master/Makefile#L24-L29 |
|
Ah, we will have to fix that up before we can switch over to consuming the CRDs from openshift/api (which I think we should do but which I also think will be a bit of work). /lgtm |
|
/approve |
|
@knobunc PTAL for approval |
|
|
||
| // observedGeneration is the most recent generation observed. | ||
| // +optional | ||
| ObservedGeneration int64 `json:"observedGeneration,omitempty"` |
There was a problem hiding this comment.
The change itself looks good, but you're getting closer to the generic OperatorStatus have you considered switching to that?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
5 participants
https://jira.coreos.com/projects/NE/issues/NE-150
operator/v1/types_ingress.go(IngressControllerStatus): AddObservedGenerationfield.operator/v1/zz_generated.swagger_doc_generated.go:Regenerate.@ironcladlou