Skip to content

kubebuilder tag needs to be on the type itself #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Oct 14, 2019
Merged

kubebuilder tag needs to be on the type itself #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion console/v1/types_console_link.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ type ConsoleLink struct {
type ConsoleLinkSpec struct {
Link `json:",inline"`
// location determines which location in the console the link will be appended to (ApplicationMenu, HelpMenu, UserMenu, NamespaceDashboard).
// +kubebuilder:validation:Pattern=^(ApplicationMenu|HelpMenu|UserMenu|NamespaceDashboard)$
Location ConsoleLinkLocation `json:"location"`
// applicationMenu holds information about section and icon used for the link in the
// application menu, and it is applicable only when location is set to ApplicationMenu.
Expand Down Expand Up @@ -52,6 +51,7 @@ type NamespaceDashboardSpec struct {
}

// ConsoleLinkLocationSelector is a set of possible menu targets to which a link may be appended.
// +kubebuilder:validation:Pattern=^(ApplicationMenu|HelpMenu|UserMenu|NamespaceDashboard)$
type ConsoleLinkLocation string

const (
Expand Down
2 changes: 1 addition & 1 deletion console/v1/types_console_notification.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ type ConsoleNotificationSpec struct {
Text string `json:"text"`
// location is the location of the notification in the console.
// +optional
// +kubebuilder:validation:Pattern=^(BannerTop|BannerBottom|BannerTopBottom)$
Location ConsoleNotificationLocation `json:"location,omitempty"`
// link is an object that holds notification link details.
// +optional
Expand All @@ -35,6 +34,7 @@ type ConsoleNotificationSpec struct {

// ConsoleNotificationLocationSelector is a set of possible notification targets
// to which a notification may be appended.
// +kubebuilder:validation:Pattern=^(BannerTop|BannerBottom|BannerTopBottom)$
type ConsoleNotificationLocation string

const (
Expand Down