Skip to content

Bug 1756132: Remove incorrect optional tag from new ingress field #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 27, 2019
Merged

Bug 1756132: Remove incorrect optional tag from new ingress field #446

openshift-merge-robot merged 1 commit into from
Sep 27, 2019

Conversation

@ironcladlou
Copy link
Contributor

@ironcladlou ironcladlou commented Sep 26, 2019

loadBalancer is a new field that contains scope, and loadBalancer is
optional (correct). However, loadBalancer.scope should be required. This
commit fixes that.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 26, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2019

@ironcladlou: This pull request references Bugzilla bug 1756132, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.2.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1756132: Remove incorrect optional tag from new ingress field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2019
@ironcladlou
Copy link
Contributor Author

ironcladlou commented Sep 26, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2019

@ironcladlou: This pull request references Bugzilla bug 1756132, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 26, 2019
Miciah
Miciah reviewed Sep 26, 2019
View reviewed changes
operator/v1/types_ingress.go
// scope indicates the scope at which the load balancer is exposed.
// Possible values are "External" and "Internal". The default is
// "External".
// +optional
Copy link
Contributor

@Miciah Miciah Sep 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but we need clarification from @deads2k regarding https://github.com/openshift/api/pull/312/files#r294390499.

Copy link
Contributor Author

@ironcladlou ironcladlou Sep 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the package default is Optional, does this need to be explicitly required?

Copy link
Contributor Author

@ironcladlou ironcladlou Sep 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked this explicitly required and moved the defaulting docs up to the actual point of defaulting (the optional loadBalancer field).

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2019
This was referenced Sep 26, 2019
Merged
Merged
@ironcladlou
Bug 1756132: Remove incorrect optional tag from new ingress field
9c9a7b1 
`loadBalancer` is a new field that contains `scope`, and `loadBalancer` is
optional (correct). However, `loadBalancer.scope` _should_ be required. This
commit fixes that.
@knobunc
Copy link
Contributor

knobunc commented Sep 27, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 27, 2019

@knobunc: This pull request references Bugzilla bug 1756132, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor

sttts commented Sep 27, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2019
@openshift-merge-robot openshift-merge-robot merged commit 86c3b77 into openshift:master Sep 27, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 27, 2019

@ironcladlou: All pull requests linked via external trackers have merged. Bugzilla bug 1756132 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1756132: Remove incorrect optional tag from new ingress field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

1 more reviewer

@Miciah Miciah Miciah left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ironcladlou @openshift-ci-robot @knobunc @sttts @Miciah @openshift-merge-robot