Skip to content

operator/ingress: make .spec.endpointPublishingStrategy.type required #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Sep 25, 2019
Merged

operator/ingress: make .spec.endpointPublishingStrategy.type required #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions operator/v1/types_ingress.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,8 @@ type EndpointPublishingStrategy struct {
// networking, and is not explicitly published. The user must manually publish
// the ingress controller.
// +unionDiscriminator
// +kubebuilder:validation:Required
Copy link
Contributor

@Miciah Miciah Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elsewhere I see +kubebuilder:validation:Required paired with +required (I would guess for consistency across various tools), so we should probably use both markers here.

Copy link
Contributor Author

@ironcladlou ironcladlou Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor

@damemi damemi Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, +required is for backwards compatibility/consistency. Both are supported

// +required
Type EndpointPublishingStrategyType `json:"type"`

// loadBalancer holds parameters for the load balancer. Present only if
Expand Down