operator/ingress: remove unnecessary +nullable markers #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `+nullable` markers removed in this commit were never actually used in the CRD we publish (See the history of [1] for evidence). Use of these markers was actually a mistake (`omitempty` is sufficient). [1] https://github.com/openshift/cluster-ingress-operator/blob/master/manifests/00-custom-resource-definition.yaml
openshift-ci-robot
added
the
size/XS
Contributor
Author
|
Given ingress-operator has never persisted |
Contributor
|
If null has never been persisted, it is safe. Note that in theory a non-Golang client (or a dynamic client) could have posted null objects and those would be persisted now. You have to judge whether this is realistic. |
Contributor
|
[1] looks convincing. You were lucky. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
ironcladlou
added a commit
to ironcladlou/library-go
that referenced
this pull request
Sep 24, 2019
Update openshift/api for openshift/api#438.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
+nullablemarkers removed in this commit were never actually usedin the CRD we publish (See the history of [1] for evidence). Use of these
markers was actually a mistake (
omitemptyis sufficient).[1] https://github.com/openshift/cluster-ingress-operator/blob/master/manifests/00-custom-resource-definition.yaml
@sttts @deads2k @damemi @Miciah