config/v1: add platform status for Azure, GCP #359
Conversation
openshift-ci-robot
added
the
size/S
* Azure: one field that is important for operators is the `Resource Group` for the cluster * GCP: 2 fields that are important for operators is the `Project` where the resources need to be created, and the `region` that should be used.
```console make generate-with-container ```
abhinavdahiya
force-pushed
the
add_gcp_status
branch
from
f2c811d to
1ac86ca
Compare
| // AzurePlatformStatus holds the current status of the Azure infrastructure provider. | ||
| type AzurePlatformStatus struct { | ||
| // resourceGroupName is the Resource Group for new Azure resources created for the cluster. | ||
| ResourceGroupName string `json:"resourceGroupName"` |
There was a problem hiding this comment.
Why not resourceGroup instead of resourceGroupName? That would be congruent to region. Is there a resourceGroupUID or something?
There was a problem hiding this comment.
Yeah, the region is always the name, but resource group can have the complete id, /subscriptions/<sid>/resourcesgroups/<rresource group name>
with resource group name, you cannot specify the subscription ID, which we do not want.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Based on openshift/api#359 that adds the platform specific status for Azure and GCP. This sets the * resource group name for the Azure platform operators that need the location, should use the location of the resource group. * add the project ID and region for the GCP platform this allows operators to create resources for the cluster correctly.
4 participants
Azure: one field that is important for operators is the
Resource Groupfor the clusterGCP: 2 fields that are important for operators is the
Projectwhere the resources need to be created, and theregionthat should be used.
The GCP fields for ingress and registry operator.
/cc @coreydaley @ironcladlou
The Azure changes are for future work on cloud-crendential-operator . the other operators currently have access to resource group from their resource group as we only support
passthrough scope:resourcegroupcreds.