Skip to content

config/v1/types_cluster_version: Add ClusterVersionSpec.AutomaticUpdates #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wking wants to merge 2 commits into from
Closed

config/v1/types_cluster_version: Add ClusterVersionSpec.AutomaticUpdates #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8a85ad
config/v1/types_cluster_version: Add ClusterVersionSpec.AutomaticUpdates
wking May 29, 2019
0b9690b
generated
wking May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions config/v1/types_cluster_version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ type ClusterVersionSpec struct {
// +optional
DesiredUpdate *Update `json:"desiredUpdate,omitempty"`

// automaticUpdates enables automatic updates.
// +optional
AutomaticUpdates bool `json:"automaticUpdates,omitempty"`
Copy link
Contributor

@abhinavdahiya abhinavdahiya May 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want people to opt-out, this API is opt-in.

Copy link
Member Author

@wking wking May 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want people to opt-out, this API is opt-in.

Existing users will need to opt in. How do we do that with an opt-out API? Can we have an opt-in API here and have an opt-out API in the install-config, so new installers will generate ClusterVersion with this set true by default?

Copy link

@chancez chancez Aug 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The zero value of a bool is false so "auto-updates=false" means "no auto updates by default", thus it's opt in.

Copy link
Member Author

@wking wking Aug 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's opt in here, and I think we want that for compat with existing clusters (which are all manual-update). If/when we add an installer knob that feeds this property, that installer knob should be opt out. Are we all on the same page, or am I missing something?


// upstream may be used to specify the preferred update server. By default
// it will use the appropriate update server for the cluster and region.
//
Expand Down
13 changes: 7 additions & 6 deletions config/v1/zz_generated.swagger_doc_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.