[release-4.21] SPLAT-2866: Add vSphere multi vCenter Day 2 by vr4manta · Pull Request #3036 · openshift/api

vr4manta · 2026-09-14T11:58:12Z

SPLAT-2866

Changes

Created new VSphereMultiVCenterDay2 feature gate
Added logic to handle day 2 processing of adding / removing vCenters

Notes

This PR is attempting to backport the following PRs:

(cherry picked from commit 76aebe7)

(cherry picked from commit 727806d)

(cherry picked from commit 43def11)

…e, and other review suggestions. (cherry picked from commit 7b21e9d)

(cherry picked from commit af78729)

(cherry picked from commit 291a26c)

…2 feature gate to TP"" (cherry picked from commit 1bf28d7)

(cherry picked from commit db1ed9c)

(cherry picked from commit 5c06b67)

The cherry-picked commits (openshift#2783, openshift#2886) used the enable(inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()) builder API added later on master; release-4.21 still uses enableIn(configv1.FeatureSet...), so the gate failed to compile. Switched to the equivalent enableIn() call and regenerated derived artifacts (features.md, openapi) to match.

openshift-ci · 2026-09-14T11:58:15Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-09-14T11:58:16Z

@vr4manta: This pull request references SPLAT-2866 which is a valid jira issue.

Details

In response to this:

SPLAT-2866

Changes

Created new VSphereMultiVCenterDay2 feature gate

Added logic to handle day 2 processing of adding / removing vCenters

Notes

This PR is attempting to backport the following PRs:

SPLAT-2649: Added vSphere Day 2 logic to CRDs #2784

Revert "TRT-2701: Revert "SPLAT-2793: Promoted VSphereMultiVCenterDay2 feature gate to TP"" #2886

SPLAT-2827: Added vSphere failure domain to vcenter check #2932

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-09-14T11:58:17Z

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

coderabbitai · 2026-09-14T11:58:17Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: efcbdd41-1848-4286-9a7f-77646e792afe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-09-14T11:59:19Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-09-14T12:31:31Z

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-crdify	`70bf390`	link	true	`/test verify-crdify`
ci/prow/verify	`70bf390`	link	true	`/test verify`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

vr4manta · 2026-09-15T17:26:41Z

/pipeline required

openshift-merge-bot · 2026-09-15T17:26:44Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-techpreview

vr4manta · 2026-09-15T17:27:41Z

/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-techpreview

redhat-chai-bot · 2026-09-15T20:48:41Z

/override-sticky ci/prow/e2e-vsphere-ovn-techpreview

Automated triage: This failure appears unrelated to the PR changes.

Job classification: Eligible long-running e2e/integration job: the presubmit uses the openshift-e2e-vsphere-ovn workflow on the vsphere-elastic cluster profile and runs e2e-vsphere-ovn-techpreview.

Revision check: run 70bf3908e3bb0e87160e4c4e5876625f633a4d40; current PR HEAD 70bf3908e3bb0e87160e4c4e5876625f633a4d40; match.

Execution status: Tests executed. Cluster installation completed, the test phase ran for 1h44m46s, and the suite recorded 1,964 passes, 1 blocking failure, 1 flaky result, and 2,117 skips. The sole blocking failure was the exact test [sig-api-machinery] CustomResourceConversionWebhook [Privileged:ClusterAdmin] should be able to convert a non homogeneous list of CRs [Conformance]; its functional assertions passed and teardown failed deleting a test-created CRD with context deadline exceeded.

Completed supporting jobs: ci/prow/e2e-vsphere-ovn passed. Other completed supporting checks included ci/prow/integration, ci/prow/unit, ci/prow/verify-crd-schema, ci/prow/verify-deps, and ci/prow/verify-feature-promotion. Pending e2e checks were not used as positive signal.

Fleet-wide failure rate: For this exact test outside this PR, the last 14 days show 16,242 passes and 12 hard failures out of 16,256 runs (99.91% pass rate), with 0 recorded flakes. All 12 failures share the same CRD cleanup context deadline exceeded signature; standard vSphere runs were 1,250/1,250 passed. The exact presubmit job has only this one run in the last 30 days.

Overlap assessment: The PR adds the VSphereMultiVCenterDay2 feature gate and vSphere Infrastructure/ControllerConfig API tests and generated schemas. The failed test exercises a Kubernetes CRD conversion webhook, passed its conversion assertions, and failed only while deleting its own test CRD during teardown. No direct overlap with the changed vSphere API definitions or feature-gate tests was found; the fleet-wide cleanup-timeout pattern is present across other constrained and upgrade environments.

Missing-coverage risk: Low for this failure: the vSphere e2e job completed its test phase, the relevant vSphere e2e job passed, and the only blocking result was a rare teardown timeout after the functional conversion assertions succeeded. Pending jobs were not counted as coverage.

Rationale: The failure is a rare, environment-sensitive CRD deletion timeout, not a failed assertion in the PR's vSphere API/feature-gate changes. The current-revision and executed-test gates pass, and fleet evidence supports treating this as unrelated.

If you disagree with this assessment, rerun the current job with /test e2e-vsphere-ovn-techpreview.

AI-generated. Review for accuracy.

openshift-ci · 2026-09-15T20:48:47Z

@redhat-chai-bot: Overrode contexts on behalf of redhat-chai-bot: ci/prow/e2e-vsphere-ovn-techpreview

These overrides will persist across retests on the current HEAD SHA. Pushing a new commit will clear them. Use /override-cancel to remove them.

Details

In response to this:

/override-sticky ci/prow/e2e-vsphere-ovn-techpreview

Automated triage: This failure appears unrelated to the PR changes.

Job classification: Eligible long-running e2e/integration job: the presubmit uses the openshift-e2e-vsphere-ovn workflow on the vsphere-elastic cluster profile and runs e2e-vsphere-ovn-techpreview.

Revision check: run 70bf3908e3bb0e87160e4c4e5876625f633a4d40; current PR HEAD 70bf3908e3bb0e87160e4c4e5876625f633a4d40; match.

Execution status: Tests executed. Cluster installation completed, the test phase ran for 1h44m46s, and the suite recorded 1,964 passes, 1 blocking failure, 1 flaky result, and 2,117 skips. The sole blocking failure was the exact test [sig-api-machinery] CustomResourceConversionWebhook [Privileged:ClusterAdmin] should be able to convert a non homogeneous list of CRs [Conformance]; its functional assertions passed and teardown failed deleting a test-created CRD with context deadline exceeded.

Completed supporting jobs: ci/prow/e2e-vsphere-ovn passed. Other completed supporting checks included ci/prow/integration, ci/prow/unit, ci/prow/verify-crd-schema, ci/prow/verify-deps, and ci/prow/verify-feature-promotion. Pending e2e checks were not used as positive signal.

Fleet-wide failure rate: For this exact test outside this PR, the last 14 days show 16,242 passes and 12 hard failures out of 16,256 runs (99.91% pass rate), with 0 recorded flakes. All 12 failures share the same CRD cleanup context deadline exceeded signature; standard vSphere runs were 1,250/1,250 passed. The exact presubmit job has only this one run in the last 30 days.

Overlap assessment: The PR adds the VSphereMultiVCenterDay2 feature gate and vSphere Infrastructure/ControllerConfig API tests and generated schemas. The failed test exercises a Kubernetes CRD conversion webhook, passed its conversion assertions, and failed only while deleting its own test CRD during teardown. No direct overlap with the changed vSphere API definitions or feature-gate tests was found; the fleet-wide cleanup-timeout pattern is present across other constrained and upgrade environments.

Missing-coverage risk: Low for this failure: the vSphere e2e job completed its test phase, the relevant vSphere e2e job passed, and the only blocking result was a rare teardown timeout after the functional conversion assertions succeeded. Pending jobs were not counted as coverage.

Rationale: The failure is a rare, environment-sensitive CRD deletion timeout, not a failed assertion in the PR's vSphere API/feature-gate changes. The current-revision and executed-test gates pass, and fleet evidence supports treating this as unrelated.

If you disagree with this assessment, rerun the current job with /test e2e-vsphere-ovn-techpreview.

AI-generated. Review for accuracy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

vr4manta and others added 10 commits September 11, 2026 11:53

Added new feature gate VSphereMultiVCenterDay2

73fa1ab

(cherry picked from commit 76aebe7)

Added vSphere Day 2 logic to CRDs

0ea095e

(cherry picked from commit 727806d)

Added vSphere Day 2 tests

43e5c0e

(cherry picked from commit 43def11)

Modified parent logic to not check size, but only changes in existenc…

97accb2

…e, and other review suggestions. (cherry picked from commit 7b21e9d)

Added some ratcheting tests to cover change in min size of vCenters

a82f010

(cherry picked from commit af78729)

Updated vcenter logic to make sure no server switching occurs

fe9ac32

(cherry picked from commit 291a26c)

Revert "TRT-2701: Revert "SPLAT-2793: Promoted VSphereMultiVCenterDay…

03fb6bc

…2 feature gate to TP"" (cherry picked from commit 1bf28d7)

Added vSphere failure domain to vcenter check

3b5ba67

(cherry picked from commit db1ed9c)

Added vSphere failure domain to vcenter ratcheting tests

1020754

(cherry picked from commit 5c06b67)

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 14, 2026

openshift-ci Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 14, 2026

openshift-ci Bot requested review from everettraven and jkyros September 14, 2026 11:59

Navigation Menu

Uh oh!

[release-4.21] SPLAT-2866: Add vSphere multi vCenter Day 2 - #3036

[release-4.21] SPLAT-2866: Add vSphere multi vCenter Day 2#3036
vr4manta wants to merge 10 commits into
openshift:release-4.21from
vr4manta:SPLAT-2866

vr4manta commented Sep 14, 2026 •

edited by openshift-ci Bot

Loading

Uh oh!

openshift-ci Bot commented Sep 14, 2026

Uh oh!

openshift-ci-robot commented Sep 14, 2026 •

edited by openshift-ci Bot

Loading

Changes

Notes

Uh oh!

openshift-ci Bot commented Sep 14, 2026

Uh oh!

coderabbitai Bot commented Sep 14, 2026

Review skipped

Uh oh!

openshift-ci Bot commented Sep 14, 2026

Uh oh!

openshift-ci Bot commented Sep 14, 2026

Uh oh!

vr4manta commented Sep 15, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 15, 2026

Uh oh!

vr4manta commented Sep 15, 2026

Uh oh!

redhat-chai-bot commented Sep 15, 2026

Uh oh!

openshift-ci Bot commented Sep 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

vr4manta commented Sep 14, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Notes

Uh oh!

openshift-ci Bot commented Sep 14, 2026

Uh oh!

openshift-ci-robot commented Sep 14, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Notes

Uh oh!

openshift-ci Bot commented Sep 14, 2026

Uh oh!

coderabbitai Bot commented Sep 14, 2026

Review skipped

Uh oh!

openshift-ci Bot commented Sep 14, 2026

Uh oh!

openshift-ci Bot commented Sep 14, 2026

Uh oh!

vr4manta commented Sep 15, 2026

Uh oh!

openshift-merge-bot Bot commented Sep 15, 2026

Uh oh!

vr4manta commented Sep 15, 2026

Uh oh!

redhat-chai-bot commented Sep 15, 2026

Uh oh!

openshift-ci Bot commented Sep 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vr4manta commented Sep 14, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Sep 14, 2026 •

edited by openshift-ci Bot

Loading