Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/v1/types_scheduling.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ type SchedulerSpec struct {
// profileCustomizations contains configuration for modifying the default behavior of existing scheduler profiles.
// Deprecated: no longer needed, since DRA is GA starting with 4.21, and
// is enabled by' default in the cluster, this field will be removed in 4.24.
// +openshift:enable:FeatureGate=DynamicResourceAllocation
// +openshift:enable:FeatureGate=HyperShiftOnlyDynamicResourceAllocation
// +optional
ProfileCustomizations ProfileCustomizations `json:"profileCustomizations"`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,28 +108,6 @@ spec:
- HighNodeUtilization
- NoScoring
type: string
profileCustomizations:
description: |-
profileCustomizations contains configuration for modifying the default behavior of existing scheduler profiles.
Deprecated: no longer needed, since DRA is GA starting with 4.21, and
is enabled by' default in the cluster, this field will be removed in 4.24.
properties:
dynamicResourceAllocation:
description: |-
dynamicResourceAllocation allows to enable or disable dynamic resource allocation within the scheduler.
Dynamic resource allocation is an API for requesting and sharing resources between pods and containers inside a pod.
Third-party resource drivers are responsible for tracking and allocating resources.
Different kinds of resources support arbitrary parameters for defining requirements and initialization.
Valid values are Enabled, Disabled and omitted.
When omitted, this means no opinion and the platform is left to choose a reasonable default,
which is subject to change over time.
The current default is Disabled.
enum:
- ""
- Enabled
- Disabled
type: string
type: object
type: object
status:
description: status holds observed values from the cluster. They may not
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,28 +108,6 @@ spec:
- HighNodeUtilization
- NoScoring
type: string
profileCustomizations:
description: |-
profileCustomizations contains configuration for modifying the default behavior of existing scheduler profiles.
Deprecated: no longer needed, since DRA is GA starting with 4.21, and
is enabled by' default in the cluster, this field will be removed in 4.24.
properties:
dynamicResourceAllocation:
description: |-
dynamicResourceAllocation allows to enable or disable dynamic resource allocation within the scheduler.
Dynamic resource allocation is an API for requesting and sharing resources between pods and containers inside a pod.
Third-party resource drivers are responsible for tracking and allocating resources.
Different kinds of resources support arbitrary parameters for defining requirements and initialization.
Valid values are Enabled, Disabled and omitted.
When omitted, this means no opinion and the platform is left to choose a reasonable default,
which is subject to change over time.
The current default is Disabled.
enum:
- ""
- Enabled
- Disabled
type: string
type: object
type: object
status:
description: status holds observed values from the cluster. They may not
Expand Down
1 change: 0 additions & 1 deletion config/v1/zz_generated.featuregated-crd-manifests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,6 @@ schedulers.config.openshift.io:
Capability: ""
Category: ""
FeatureGates:
- DynamicResourceAllocation
- HyperShiftOnlyDynamicResourceAllocation
FilenameOperatorName: config-operator
FilenameOperatorOrdering: "01"
Expand Down

This file was deleted.

1 change: 0 additions & 1 deletion features.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
| DNSNameResolver| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| DualReplica| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| DyanmicServiceEndpointIBMCloud| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| DynamicResourceAllocation| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| EtcdBackendQuota| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| EventTTL| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| Example| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
Expand Down
8 changes: 0 additions & 8 deletions features/features.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,6 @@ var (
enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
mustRegister()

FeatureGateDynamicResourceAllocation = newFeatureGate("DynamicResourceAllocation").
reportProblemsToJiraComponent("scheduling").
contactPerson("jchaloup").
productScope(kubernetes).
enhancementPR("https://github.com/kubernetes/enhancements/issues/4381").
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
mustRegister()

FeatureGateAzureWorkloadIdentity = newFeatureGate("AzureWorkloadIdentity").
reportProblemsToJiraComponent("cloud-credential-operator").
contactPerson("abutcher").
Expand Down
2 changes: 1 addition & 1 deletion openapi/openapi.json
Original file line number Diff line number Diff line change
Expand Up @@ -10811,7 +10811,7 @@
"type": "string"
},
"profileCustomizations": {
"description": "profileCustomizations contains configuration for modifying the default behavior of existing scheduler profiles.",
"description": "profileCustomizations contains configuration for modifying the default behavior of existing scheduler profiles. Deprecated: no longer needed, since DRA is GA starting with 4.21, and is enabled by' default in the cluster, this field will be removed in 4.24.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix typo in deprecation description.

The description string contains a syntax error: "by' default" should be "by default" (the errant quote character should be removed).

Apply this diff to fix the typo:

-          "description": "profileCustomizations contains configuration for modifying the default behavior of existing scheduler profiles. Deprecated: no longer needed, since DRA is GA starting with 4.21, and is enabled by' default in the cluster, this field will be removed in 4.24.",
+          "description": "profileCustomizations contains configuration for modifying the default behavior of existing scheduler profiles. Deprecated: no longer needed, since DRA is GA starting with 4.21, and is enabled by default in the cluster, this field will be removed in 4.24.",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"description": "profileCustomizations contains configuration for modifying the default behavior of existing scheduler profiles. Deprecated: no longer needed, since DRA is GA starting with 4.21, and is enabled by' default in the cluster, this field will be removed in 4.24.",
"description": "profileCustomizations contains configuration for modifying the default behavior of existing scheduler profiles. Deprecated: no longer needed, since DRA is GA starting with 4.21, and is enabled by default in the cluster, this field will be removed in 4.24.",
🤖 Prompt for AI Agents
In openapi/openapi.json around line 10814, the deprecation description contains
a typo: the substring "by' default" includes an errant single quote; remove the
stray quote so it reads "by default" and update the JSON string accordingly,
ensuring proper JSON escaping and that the surrounding punctuation/spacing
remains unchanged.

"default": {},
"$ref": "#/definitions/com.github.openshift.api.config.v1.ProfileCustomizations"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,28 +108,6 @@ spec:
- HighNodeUtilization
- NoScoring
type: string
profileCustomizations:
description: |-
profileCustomizations contains configuration for modifying the default behavior of existing scheduler profiles.
Deprecated: no longer needed, since DRA is GA starting with 4.21, and
is enabled by' default in the cluster, this field will be removed in 4.24.
properties:
dynamicResourceAllocation:
description: |-
dynamicResourceAllocation allows to enable or disable dynamic resource allocation within the scheduler.
Dynamic resource allocation is an API for requesting and sharing resources between pods and containers inside a pod.
Third-party resource drivers are responsible for tracking and allocating resources.
Different kinds of resources support arbitrary parameters for defining requirements and initialization.
Valid values are Enabled, Disabled and omitted.
When omitted, this means no opinion and the platform is left to choose a reasonable default,
which is subject to change over time.
The current default is Disabled.
enum:
- ""
- Enabled
- Disabled
type: string
type: object
type: object
status:
description: status holds observed values from the cluster. They may not
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,28 +108,6 @@ spec:
- HighNodeUtilization
- NoScoring
type: string
profileCustomizations:
description: |-
profileCustomizations contains configuration for modifying the default behavior of existing scheduler profiles.
Deprecated: no longer needed, since DRA is GA starting with 4.21, and
is enabled by' default in the cluster, this field will be removed in 4.24.
properties:
dynamicResourceAllocation:
description: |-
dynamicResourceAllocation allows to enable or disable dynamic resource allocation within the scheduler.
Dynamic resource allocation is an API for requesting and sharing resources between pods and containers inside a pod.
Third-party resource drivers are responsible for tracking and allocating resources.
Different kinds of resources support arbitrary parameters for defining requirements and initialization.
Valid values are Enabled, Disabled and omitted.
When omitted, this means no opinion and the platform is left to choose a reasonable default,
which is subject to change over time.
The current default is Disabled.
enum:
- ""
- Enabled
- Disabled
type: string
type: object
type: object
status:
description: status holds observed values from the cluster. They may not
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,6 @@
{
"name": "DyanmicServiceEndpointIBMCloud"
},
{
"name": "DynamicResourceAllocation"
},
{
"name": "EtcdBackendQuota"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,6 @@
{
"name": "DyanmicServiceEndpointIBMCloud"
},
{
"name": "DynamicResourceAllocation"
},
{
"name": "EtcdBackendQuota"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,6 @@
{
"name": "DyanmicServiceEndpointIBMCloud"
},
{
"name": "DynamicResourceAllocation"
},
{
"name": "EtcdBackendQuota"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,6 @@
{
"name": "DyanmicServiceEndpointIBMCloud"
},
{
"name": "DynamicResourceAllocation"
},
{
"name": "EtcdBackendQuota"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,6 @@
{
"name": "DyanmicServiceEndpointIBMCloud"
},
{
"name": "DynamicResourceAllocation"
},
{
"name": "EtcdBackendQuota"
},
Expand Down
Loading