Skip to content

Conversation

@benluddy
Copy link
Contributor

@benluddy benluddy commented Nov 5, 2025

No description provided.

@openshift-ci-robot
Copy link

Pipeline controller notification
This repository is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. Review these jobs and use /test <job> to manually trigger optional jobs most likely to be impacted by the proposed changes.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 5, 2025
@openshift-ci-robot
Copy link

@benluddy: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

Hello @benluddy! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@benluddy
Copy link
Contributor Author

benluddy commented Nov 5, 2025

/hold

#2562

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2025
@openshift-ci openshift-ci bot requested review from JoelSpeed and deads2k November 5, 2025 16:44
@JoelSpeed
Copy link
Contributor

/payload-aggregate periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance 10

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

@JoelSpeed: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b58da0b0-baff-11f0-985e-bdbcc80f3522-0

@benluddy
Copy link
Contributor Author

benluddy commented Nov 7, 2025

/hold cancel
#2562 (comment)

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2025
@benluddy
Copy link
Contributor Author

benluddy commented Nov 7, 2025

/assign @deads2k

@JoelSpeed
Copy link
Contributor

/lgtm
/label backport-risk-assessed
/labe jira/valid-bug

Green payload aggregate, 4.18 has merged

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 7, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2025
@JoelSpeed
Copy link
Contributor

/pipeline required

@sdodson sdodson added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 9, 2025
@sdodson
Copy link
Member

sdodson commented Nov 9, 2025

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 9, 2025
@openshift-ci-robot
Copy link

@sdodson: This PR has been marked as verified by CI.

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b410df2 and 2 for PR HEAD be345ab in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2025

@benluddy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Nov 9, 2025

/pipeline required

@sdodson
Copy link
Member

sdodson commented Nov 10, 2025

/pipeline ?

@sdodson
Copy link
Member

sdodson commented Nov 10, 2025

Those jobs show as having passed in history. I'm assuming that the pipeline feature is either broken or I just don't understand it.

@sdodson sdodson merged commit b315b8f into openshift:release-4.17 Nov 10, 2025
19 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants