Skip to content

no-jira: Rename some Installer feature gates #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
patrickdillon wants to merge 3 commits into from
Closed

no-jira: Rename some Installer feature gates #2421

patrickdillon wants to merge 3 commits into from

Conversation

@patrickdillon
Copy link
Contributor

@patrickdillon patrickdillon commented Jul 24, 2025

This PR renames a few installer feature gates we are looking to promote soon. Installer feature gates should have "install" in the title so that the test analyzer will analyze install success--not a specific e2e test.. We forgot that convention when creating these feature gates, so we need to rename them.

@patrickdillon
features: rename AWSClusterHostedDNS -> AWSClusterHostedDNSInstall
82aac0a 
Installer feature gates need to have "Install" in the name so that
the proper tests are used for promotion analysis.
@patrickdillon
features: rename GCPClusterHostedDNS -> GCPClusterHostedDNSInstall
4a93f5a 
Installer feature gates need to have "Install" in the name in order
for the promotion test analyzer to select the install tests as a
standard.
@patrickdillon
features: rename GCPCustomAPIEndpoints -> GCPCustomAPIEndpointsInstall
386d384 
Installer feature gates should include "install" in the name so that
the correct tests are analyzed for feature gate promotion.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 24, 2025

@patrickdillon: This pull request explicitly references no jira issue.

Details

In response to this:

This PR renames a few installer feature gates we are looking to promote soon. Installer feature gates should have "install" in the title so that the test analyzer will analyze install success--not a specific e2e test.. We forgot that convention when creating these feature gates, so we need to rename them.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

Hello @patrickdillon! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@patrickdillon
Copy link
Contributor Author

patrickdillon commented Jul 24, 2025 •
edited
Loading

cc @barbacbd @sadasu @jianlinliu @gpei @yunjiang29

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 24, 2025
@openshift-ci openshift-ci bot requested review from cgwalters and deads2k July 24, 2025 15:58
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: patrickdillon
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@patrickdillon
Copy link
Contributor Author

patrickdillon commented Jul 24, 2025

/hold

joel suggested I try instead the approach in #2423

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview-2of2 386d384 link true /test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-aws-ovn 386d384 link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-techpreview 386d384 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-serial-1of2 386d384 link true /test e2e-aws-serial-1of2
ci/prow/e2e-gcp 386d384 link false /test e2e-gcp
ci/prow/e2e-aws-ovn-hypershift 386d384 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-serial-techpreview-1of2 386d384 link true /test e2e-aws-serial-techpreview-1of2
ci/prow/e2e-upgrade-out-of-change 386d384 link true /test e2e-upgrade-out-of-change
ci/prow/e2e-azure 386d384 link false /test e2e-azure
ci/prow/verify 386d384 link true /test verify
ci/prow/okd-scos-e2e-aws-ovn 386d384 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-upgrade 386d384 link true /test e2e-upgrade
ci/prow/e2e-aws-ovn-hypershift-conformance 386d384 link true /test e2e-aws-ovn-hypershift-conformance
ci/prow/minor-e2e-upgrade-minor 386d384 link true /test minor-e2e-upgrade-minor
ci/prow/e2e-aws-serial-2of2 386d384 link true /test e2e-aws-serial-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor Author

patrickdillon commented Jul 25, 2025

/close
in favor of #2423

@openshift-ci openshift-ci bot closed this Jul 25, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2025

@patrickdillon: Closed this PR.

Details

In response to this:

/close
in favor of #2423

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@deads2k deads2k Awaiting requested review from deads2k

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@patrickdillon @openshift-ci-robot