features: client generator expects singular objects

[rphillips]

I was getting this error on my informer. Note FeatureList does not exist, and FeaturesList does. We need to redo the pluralization and update the go-client.

I0305 14:38:13.242898   22751 reflector.go:169] Listing and watching *v1.Features from github.com/openshift/client-go/config/informers/externalversions/factory.go:101
E0305 14:38:13.244280   22751 reflector.go:134] github.com/openshift/client-go/config/informers/externalversions/factory.go:101: Failed to list *v1.Features: no kind "FeatureList" is registered for version "config.openshift.io/v1" in scheme "github.com/openshift/client-go/c
onfig/clientset/versioned/scheme/register.go:14" 

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rphillips
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jwforres

If they are not already assigned, you can assign the PR to them by writing /assign @jwforres in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rphillips]

/cc @derekwaynecarr @deads2k

[sjenning]

@rphillips are we sure this is the issue?
@deads2k not sure if this is how we want to fix it if it is.

[rphillips]

@sjenning I'm pretty certain the generator works this way. We can force the pluralization constructs with a comment, but we should probably conform to the defaults.

[deads2k]

/hold

No, we need a generator fix. Maybe it didn't publish

[openshift-ci-robot]

@rphillips: The following test failed for commit a4bd8fa, say /retest to rerun them:

Test name	Details	Rerun command
ci/prow/verify-client-go	link	/test verify-client-go

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sjenning]

i think we should adhere to the upstream convention for resource naming rather than special-case the code generator. @deads2k what do you think?

[rphillips]

Closing in favor of openshift/kubernetes-code-generator#1 openshift/origin#22281