OCPNODE-3225,OCPNODE-2557: features: set user namespace features on by default #2305
Conversation
|
Hello @haircommander! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/M
haircommander
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@haircommander: This pull request references OCPNODE-3225 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. This pull request references OCPNODE-2557 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
haircommander
force-pushed
the
userns-default
branch
from
bc4da2e to
b8c88d3
Compare
openshift-ci
bot
added
size/XS
haircommander
force-pushed
the
userns-default
branch
from
b8c88d3 to
ae6eca6
Compare
openshift-ci
bot
added
size/XXL
haircommander
force-pushed
the
userns-default
branch
from
ae6eca6 to
7682b37
Compare
| items: | ||
| type: string | ||
| maxItems: 10 | ||
| maxItems: 1 |
There was a problem hiding this comment.
i'm unsure why this snuck in
There was a problem hiding this comment.
Please make sure you're rebased on the latest tip of master and try the generation again 🤔
There was a problem hiding this comment.
this happened to me on master too, but I just dropped manually
|
/retest |
haircommander
force-pushed
the
userns-default
branch
2 times, most recently
from
3e545e7 to
f08ce86
Compare
Signed-off-by: Peter Hunt <[email protected]>
haircommander
force-pushed
the
userns-default
branch
from
199f431 to
0f9a8e8
Compare
|
/retest I think the remaining verify failures are expected. We have this weird deadlock where upstream userns tests will fail because the feature is turned off, but they're only enabled in tech preview clusters so we don't have any feedback that they're working. If needed, I could duplicate the upstream tests in o/origin to mimic the upstream behaviors, but we still would need to wait a bit to get test readiness. OR we can override. I ask because this is blocking @bertinatto 's rebase and needs timely consideration. WDYT @JoelSpeed |
|
/test e2e-aws-serial |
|
This PR, as far as I can tell, is still enabling 3 features by default. My understanding was that it should be enabling 2 of them? Can we try to get that fixed. The verify failures in crd-schema do appear to be legacy failures that we cannot yet fix, so I'd be happy to override that one |
|
I think we should be enabling all three, which do you think should be dropped? |
|
Sorry, I thought procmounttype was being enabled separately, in which case everything here appears to be in order /override ci/prow/verify-crd-schema Pre-existing failures, we cannot otherwise resolve /lgtm /hold What are we doing about test requirements for upstream gates 🤔 |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@haircommander: This PR was included in a payload test run from openshift/kubernetes#2239 |
1 similar comment
|
@haircommander: This PR was included in a payload test run from openshift/kubernetes#2239 |
|
/payload-job-with-prs k8s-e2e-gcp-ovn openshift/kubernetes#2239 |
|
@haircommander: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
@bertinatto: This PR was included in a payload test run from openshift/kubernetes#2239
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/371d5310-2f3b-11f0-9e82-430f9ff9973c-0 |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
Based on the results of combining this PR with the PR to re-enable the tests, we can see that the upstream feature is passing /override ci/prow/verify-feature-promotion /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-serial |
|
/retest-required |
|
/override ci/prow/verify-feature-promotion |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema, ci/prow/verify-feature-promotion In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-serial Tests passed but timed out on deprovision |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-serial In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@haircommander: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/skip |
|
/test e2e-aws-ovn-techpreview |
4 participants
now that we are approaching kube 1.33 rebase (and are moving away from 1.32), we are safe from the risks that caused us not to turn this on by default (needing a n-3 version skew to 1.30 to make sure a user namespace is created or a pod is denied)