NE-2017: Enable GatewayAPIController featuregate in Default featureset #2284

alebedev87 · 2025-04-16T08:35:17Z

Promote the GatewayAPIController feature gate to GA by enabling it in the default feature set. This featuregate governs the OpenShift Gateway API controller implementation, which is currently based on Istio.

openshift-ci-robot · 2025-04-16T08:35:21Z

@alebedev87: This pull request references NE-2017 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Promote the GatewayAPIController feature gate to GA by enabling it in the default feature set. This featuregate governs the OpenShift Gateway API controller implementation, which is currently based on Istio.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-04-16T08:35:23Z

Hello @alebedev87! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

alebedev87 · 2025-04-16T20:56:30Z

/retest

lihongan · 2025-04-17T02:35:51Z

/retest-required

JoelSpeed · 2025-04-17T08:52:46Z

Out of interest, is there a problem in the product if GatewayAPI ships without GatewayAPIController? What would happen in a cluster with only GatewayAPI and no GatewayAPIController?

alebedev87 · 2025-04-17T13:03:36Z

Out of interest, is there a problem in the product if GatewayAPI ships without GatewayAPIController? What would happen in a cluster with only GatewayAPI and no GatewayAPIController?

GatewayAPI featuregate covers the management of the GatewayAPI CRDs. So, if only GatewayAPI featuregate will be promoted we reserve the ownership of GatewayAPI - nobody else but the cluster ingress operator will be able to manage (create/update/delete) GatewayAPI CRDs. And if cluster admin will create OpenShift's gatewayclass the cluster ingress operator will create the expected versions of GatewayAPI CRDs.

GatewayAPIController manages the implementation of anything which is under the gateway class. The implementation is done by OpenShift Service Mesh. So, if GatewayAPIController won't be promoted, users will be able to create GatewayAPI custom resources but there will be no implementation to back them up.

knobunc · 2025-04-17T14:18:07Z

So, if GatewayAPIController won't be promoted, users will be able to create GatewayAPI custom resources but there will be no implementation to back them up.

There may be no default implementation. But there are third-party ones (including Red Hat Connectivity Link) that use the APIs. Since it is so widely used, we need to be the referee and control which version is used. Especially since we will be shipping a default implementation soon.

knobunc · 2025-04-17T14:56:40Z

/lgtm

I am not an approver, but I approve of the gate lift.

JoelSpeed · 2025-04-17T15:05:21Z

Feature promotion isn't showing many test runs so far, are the tests in the pipeline?

Tests are expected to be merged by tomorrow is my current understanding, which should then give us up to a week to promote features up until the 25th

candita · 2025-04-17T16:23:18Z

/test e2e-upgrade

Miciah · 2025-04-17T16:52:41Z

Out of interest, is there a problem in the product if GatewayAPI ships without GatewayAPIController?

No.

What would happen in a cluster with only GatewayAPI and no GatewayAPIController?

We would force OpenShift clusters to have a specific Gateway API CRD version, without shipping a controller that implemented the API. It would be awkward and potentially frustrating to people who want to use a third-party Gateway API implementation that requires a different version of the CRDs, but nothing would be broken in the product.

Edit: Now that I have posted my comment, GitHub shows me that others have already answered your questions. Sorry for the redundancy!

candita · 2025-04-17T19:50:25Z

failed: (5m1s) 2025-04-16T22:27:33 "[sig-node] Pods Extended Pod Container lifecycle evicted pods should be terminal [Suite:openshift/conformance/parallel] [Suite:k8s]"
failed: (31.3s) 2025-04-16T22:53:07 "[sig-imageregistry] Image registry [apigroup:route.openshift.io] should redirect on blob pull [apigroup:image.openshift.io] [Skipped:NoOptionalCapabilities] [Suite:openshift/conformance/parallel]"

/test e2e-aws-ovn

lihongan · 2025-04-18T08:26:52Z

/test verify-feature-promotion

Let's see if we get more tests in CI

knobunc · 2025-04-18T14:10:47Z

=======

Posting to note that this is when #2284 merged, so tests results from before this time are not entirely trustworthy.

=======

Promotes the `GatewayAPIController` feature gate to GA by enabling it in the default feature set. This featuregate governs the OpenShift Gateway API controller implementation, which is currently based on Istio.

candita · 2025-04-18T15:21:54Z

/lgtm

JoelSpeed · 2025-04-18T15:33:58Z

Do we have any testing being set up for metal/vSphere? That seems to be missing right now.

alebedev87 · 2025-04-22T12:33:02Z

minor-e2e-upgrade-minor and e2e-upgrade failed due to AWS quote slice missing: slack thread.

Message from testplatform:

The recovering is slow, you might find 1. certain isolated images are not available (although most release images are restored); 2.  test failure due to out of lease/AWS quota. Please do not repeatedly run tests... we are still in the recovery phase.

alebedev87 · 2025-04-22T12:46:14Z

e2e-aws-ovn timed out.

/test e2e-aws-ovn

alebedev87 · 2025-04-22T12:47:21Z

/test e2e-aws-serial-techpreview

e2e-aws-serial-techpreview timed out.

alebedev87 · 2025-04-22T18:28:53Z

/test e2e-upgrade
/test minor-e2e-upgrade-minor

alebedev87 · 2025-04-22T21:42:24Z

/retest-required

lihongan · 2025-04-23T03:19:24Z

/retest-required

alebedev87 · 2025-04-23T06:04:57Z

/test e2e-upgrade

alebedev87 · 2025-04-23T08:04:29Z

/test e2e-upgrade

alebedev87 · 2025-04-23T09:30:30Z

Sippy is 94.2% for Azure. Let's see whether the verify job rounds up.

/test verify-feature-promotion

Upd: nope

alebedev87 · 2025-04-23T12:44:49Z

/test verify-feature-promotion

alebedev87 · 2025-04-23T16:03:03Z

/test verify-feature-promotion

alebedev87 · 2025-04-23T19:31:52Z

/test verify-feature-promotion

candita · 2025-04-24T00:29:20Z

/test verify-feature-promotion
The prior failures on verify-feature-promotion:

INSUFFICIENT CI testing for "GatewayAPIController".
F0423 19:43:31.690260 10497 root.go:64] Error running codegen: error: "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] Ensure OSSM and OLM related resources are created after creating GatewayClass [Suite:openshift/conformance/parallel]" only passed 93%, need at least 95% for "GatewayAPIController" on {gcp amd64 ha }
error: only 0 tests found, need at least 5 for "GatewayAPIController" on {vsphere amd64 ha }
error: only 0 tests found, need at least 5 for "GatewayAPIController" on {metal amd64 ha ipv4}
error: only 0 tests found, need at least 5 for "GatewayAPIController" on {metal amd64 ha ipv6}
error: only 0 tests found, need at least 5 for "GatewayAPIController" on {metal amd64 ha dual}

lihongan · 2025-04-24T01:56:14Z

verify-feature-promotion looks good now (with exception on metal/vsphere)

/label qe-approved

openshift-ci-robot · 2025-04-24T01:56:20Z

@alebedev87: This pull request references NE-2017 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Promote the GatewayAPIController feature gate to GA by enabling it in the default feature set. This featuregate governs the OpenShift Gateway API controller implementation, which is currently based on Istio.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

JoelSpeed · 2025-04-24T07:45:47Z

/lgtm
/override ci/prow/verify-feature-promotion

Pass rate is acceptable for cloud platforms, on prem platforms will be handled as a separate gate later

openshift-ci · 2025-04-24T07:47:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, candita, JoelSpeed, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-04-24T07:47:22Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion

Details

In response to this:

/lgtm
/override ci/prow/verify-feature-promotion

Pass rate is acceptable for cloud platforms, on prem platforms will be handled as a separate gate later

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-04-24T08:27:07Z

/retest-required

Remaining retests: 0 against base HEAD 6bababe and 2 for PR HEAD 2845df3 in total

alebedev87 · 2025-04-24T09:37:57Z

/test images

alebedev87 · 2025-04-24T09:46:57Z

/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance

504 Gateway Time-out for the CI image registry.

openshift-ci-robot · 2025-04-24T11:27:00Z

/retest-required

Remaining retests: 0 against base HEAD eb41266 and 1 for PR HEAD 2845df3 in total

alebedev87 · 2025-04-24T12:01:55Z

/test e2e-aws-serial

The e2e passed however the deprovision could not finish in time.

openshift-ci-robot · 2025-04-24T12:36:16Z

/retest-required

Remaining retests: 0 against base HEAD eb41266 and 2 for PR HEAD 2845df3 in total

sdodson · 2025-04-24T12:44:30Z

Merging manually to avoid endless retests on changes.

openshift-ci · 2025-04-24T12:45:07Z

@alebedev87: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`2845df3`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-aws-ovn-hypershift	`2845df3`	link	true	`/test e2e-aws-ovn-hypershift`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 16, 2025

openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 16, 2025

openshift-ci bot requested review from JoelSpeed and everettraven April 16, 2025 08:36

openshift-ci bot assigned knobunc Apr 17, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2025

knobunc assigned JoelSpeed Apr 17, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2025

NE-2017: Enable GatewayAPIController featuregate in Default featureset

2845df3

Promotes the `GatewayAPIController` feature gate to GA by enabling it in the default feature set. This featuregate governs the OpenShift Gateway API controller implementation, which is currently based on Istio.

alebedev87 force-pushed the gatewayapi-controller-ga branch from ff2accb to 2845df3 Compare April 18, 2025 14:50

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2025

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2025

openshift-ci bot assigned candita Apr 18, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2025

alebedev87 mentioned this pull request Apr 23, 2025

OCPBUGS-55211: use regular user to create httproute openshift/origin#29697

Merged

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 24, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2025

sdodson merged commit 3e98cae into openshift:master Apr 24, 2025
19 of 24 checks passed

NE-2017: Enable GatewayAPIController featuregate in Default featureset #2284

NE-2017: Enable GatewayAPIController featuregate in Default featureset #2284

Uh oh!

Conversation

alebedev87 commented Apr 16, 2025

Uh oh!

openshift-ci-robot commented Apr 16, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 16, 2025

Uh oh!

alebedev87 commented Apr 16, 2025

Uh oh!

lihongan commented Apr 17, 2025

Uh oh!

JoelSpeed commented Apr 17, 2025

Uh oh!

alebedev87 commented Apr 17, 2025

Uh oh!

knobunc commented Apr 17, 2025

Uh oh!

knobunc commented Apr 17, 2025

Uh oh!

JoelSpeed commented Apr 17, 2025

Uh oh!

candita commented Apr 17, 2025

Uh oh!

Miciah commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

candita commented Apr 17, 2025

Uh oh!

lihongan commented Apr 18, 2025

Uh oh!

knobunc commented Apr 18, 2025

Uh oh!

candita commented Apr 18, 2025

Uh oh!

JoelSpeed commented Apr 18, 2025

Uh oh!

alebedev87 commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alebedev87 commented Apr 22, 2025

Uh oh!

alebedev87 commented Apr 22, 2025

Uh oh!

alebedev87 commented Apr 22, 2025

Uh oh!

alebedev87 commented Apr 22, 2025

Uh oh!

lihongan commented Apr 23, 2025

Uh oh!

alebedev87 commented Apr 23, 2025

Uh oh!

alebedev87 commented Apr 23, 2025

Uh oh!

alebedev87 commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alebedev87 commented Apr 23, 2025

Uh oh!

alebedev87 commented Apr 23, 2025

Uh oh!

alebedev87 commented Apr 23, 2025

Uh oh!

candita commented Apr 24, 2025

Uh oh!

lihongan commented Apr 24, 2025

Uh oh!

openshift-ci-robot commented Apr 24, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoelSpeed commented Apr 24, 2025

Uh oh!

openshift-ci bot commented Apr 24, 2025

Uh oh!

openshift-ci bot commented Apr 24, 2025

Uh oh!

openshift-ci-robot commented Apr 24, 2025

openshift-ci-robot commented Apr 16, 2025 •

edited by openshift-ci bot

Loading

Miciah commented Apr 17, 2025 •

edited

Loading

alebedev87 commented Apr 22, 2025 •

edited

Loading

alebedev87 commented Apr 23, 2025 •

edited

Loading

openshift-ci-robot commented Apr 24, 2025 •

edited by openshift-ci bot

Loading