-
Notifications
You must be signed in to change notification settings - Fork 582
CNTRLPLANE-5: Add CBOR feature gate #2235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNTRLPLANE-5: Add CBOR feature gate #2235
Conversation
|
Hello @bertinatto! Some important instructions when contributing to openshift/api: |
|
@bertinatto: This PR was included in a payload test run from openshift/origin#29601
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb18fb60-00e3-11f0-954e-e5104ec1769c-0 |
|
@bertinatto: This pull request references CNTRLPLANE-5 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bertinatto: This PR was included in a payload test run from openshift/origin#29601
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/daacde90-0102-11f0-9446-602cd77896e3-0 |
|
@bertinatto: This pull request references CNTRLPLANE-5 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
28c2919 to
9df67b9
Compare
|
@bertinatto: This PR was included in a payload test run from openshift/cluster-kube-controller-manager-operator#836
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8543cf00-0386-11f0-88e2-18ded3b7324c-0 |
|
/test all |
|
@bertinatto: No presubmit jobs available for openshift/api@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@bertinatto: This PR was included in a payload test run from openshift/cluster-kube-controller-manager-operator#836
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/586fa690-03ed-11f0-84e0-c6a332c9fc36-0 |
|
/test all |
|
@bertinatto: No presubmit jobs available for openshift/api@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@bertinatto: This PR was included in a payload test run from openshift/cluster-kube-controller-manager-operator#836
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d6bd4c40-0420-11f0-8fa0-4b4731e3323c-0 |
|
@bertinatto: This PR was included in a payload test run from openshift/cluster-kube-controller-manager-operator#836
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5f2a0c40-043e-11f0-811a-c450532f4e61-0 |
9df67b9 to
006bc17
Compare
|
/retest |
1b0f268 to
3593cda
Compare
2cca735 to
1780521
Compare
|
Changes here LGTM, will approve so that you can self serve merge when you're ready |
|
/retest |
|
/hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, bertinatto, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by @benluddy |
|
@benluddy: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-serial-techpreview-1of2 |
|
/retest-required |
|
/retest |
|
@bertinatto: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
No description provided.