Skip to content

Conversation

@bertinatto
Copy link
Member

@bertinatto bertinatto commented Mar 13, 2025

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2025

Hello @bertinatto! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 13, 2025
@openshift-ci openshift-ci bot requested review from bparees and knobunc March 13, 2025 21:40
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

@bertinatto: This PR was included in a payload test run from openshift/origin#29601
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb18fb60-00e3-11f0-954e-e5104ec1769c-0

@bertinatto bertinatto changed the title WIP: Add CBOR feature gate [WIP] CNTRLPLANE-5: Add CBOR feature gate Mar 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 14, 2025

@bertinatto: This pull request references CNTRLPLANE-5 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 14, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

@bertinatto: This PR was included in a payload test run from openshift/origin#29601
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/daacde90-0102-11f0-9446-602cd77896e3-0

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 17, 2025

@bertinatto: This pull request references CNTRLPLANE-5 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CBOR serving and storage in apiserver should be TechPreview in 4.19, so we need to adjust our test to accept that type of storage in etcd.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bertinatto bertinatto force-pushed the add-cbor-feature-gate branch from 28c2919 to 9df67b9 Compare March 17, 2025 20:37
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2025

@bertinatto: This PR was included in a payload test run from openshift/cluster-kube-controller-manager-operator#836
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8543cf00-0386-11f0-88e2-18ded3b7324c-0

@bertinatto
Copy link
Member Author

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

@bertinatto: No presubmit jobs available for openshift/api@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

@bertinatto: This PR was included in a payload test run from openshift/cluster-kube-controller-manager-operator#836
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/586fa690-03ed-11f0-84e0-c6a332c9fc36-0

@bertinatto
Copy link
Member Author

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

@bertinatto: No presubmit jobs available for openshift/api@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

@bertinatto: This PR was included in a payload test run from openshift/cluster-kube-controller-manager-operator#836
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d6bd4c40-0420-11f0-8fa0-4b4731e3323c-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

@bertinatto: This PR was included in a payload test run from openshift/cluster-kube-controller-manager-operator#836
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5f2a0c40-043e-11f0-811a-c450532f4e61-0

@bertinatto bertinatto force-pushed the add-cbor-feature-gate branch from 9df67b9 to 006bc17 Compare March 19, 2025 13:12
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 19, 2025
@bertinatto
Copy link
Member Author

/retest

@bertinatto bertinatto force-pushed the add-cbor-feature-gate branch 2 times, most recently from 1b0f268 to 3593cda Compare March 20, 2025 21:22
@bertinatto bertinatto force-pushed the add-cbor-feature-gate branch from 2cca735 to 1780521 Compare September 5, 2025 13:12
@JoelSpeed
Copy link
Contributor

Changes here LGTM, will approve so that you can self serve merge when you're ready
/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2025
@benluddy
Copy link
Contributor

benluddy commented Sep 5, 2025

/retest

@benluddy
Copy link
Contributor

benluddy commented Sep 7, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2025
@benluddy
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, bertinatto, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benluddy
Copy link
Contributor

/verified by @benluddy

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 10, 2025
@openshift-ci-robot
Copy link

@benluddy: This PR has been marked as verified by @benluddy.

In response to this:

/verified by @benluddy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD be976da and 2 for PR HEAD 1780521 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e515d9c and 1 for PR HEAD 1780521 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e515d9c and 2 for PR HEAD 1780521 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9116741 and 1 for PR HEAD 1780521 in total

@benluddy
Copy link
Contributor

/test e2e-aws-serial-techpreview-1of2

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2acafd4 and 2 for PR HEAD 1780521 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c71c7b2 and 1 for PR HEAD 1780521 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c71c7b2 and 2 for PR HEAD 1780521 in total

@JoelSpeed
Copy link
Contributor

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c71c7b2 and 2 for PR HEAD 1780521 in total

@bertinatto
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c71c7b2 and 2 for PR HEAD 1780521 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

@bertinatto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview 0984948 link true /test e2e-aws-serial-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bertinatto
Copy link
Member Author

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 61248d9 into openshift:master Sep 13, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants