Skip to content

Conversation

@ffromani
Copy link

@ffromani ffromani commented Dec 4, 2024

add feature gate to enable selected users to consume cpumanager policy options of alfpha maturtiy.
Needs to be merged alongside openshift/kubernetes#2136 which enables per-option granularity

for more details: openshift/enhancements#1724

add feature gate to enable selected users to consume
cpumanager policy options of alfpha maturtiy.
Needs to be merged alongside openshift/kubernetes#2136
which enables per-option granularity

for more details: openshift/enhancements#1724

Signed-off-by: Francesco Romani <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

Hello @ffromani! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2024
@openshift-ci openshift-ci bot requested review from JoelSpeed and deads2k December 4, 2024 15:48
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ffromani
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

@ffromani: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 879173d link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ffromani
Copy link
Author

no longer needed per discussion in openshift/enhancements#1724

@ffromani ffromani closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant