Skip to content

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Jul 3, 2024

@r4f4
Copy link
Contributor Author

r4f4 commented Jul 3, 2024

/cc @jeffdyoung

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2024

Hello @r4f4! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot requested a review from jeffdyoung July 3, 2024 08:14
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 3, 2024
@openshift-ci openshift-ci bot requested review from JoelSpeed and soltysh July 3, 2024 08:17
@r4f4
Copy link
Contributor Author

r4f4 commented Jul 3, 2024

Example of usage in the installer: openshift/installer@88ce9a8

@r4f4
Copy link
Contributor Author

r4f4 commented Jul 3, 2024

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2024

@r4f4: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 01da8e8 into openshift:master Jul 4, 2024
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.17.0-202407040842.p0.g01da8e8.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants