Skip to content

Comments

features: add capi-installer gate per platform#1868

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
patrickdillon:capi-install-gates
Apr 25, 2024
Merged

features: add capi-installer gate per platform#1868
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
patrickdillon:capi-install-gates

Conversation

@patrickdillon
Copy link
Contributor

Adds a capi-installer feature gate for each platform.

/cc @JoelSpeed @deads2k

FYI:
@r4f4
@jhixson74
@bfournie
@cjschaef
@yanhua121
@stephenfin
@mjturek
@rvanderp3

Adds a capi-installer feature gate for each platform.
@openshift-ci openshift-ci bot requested review from JoelSpeed and deads2k April 23, 2024 18:36
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

Hello @patrickdillon! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 23, 2024
@r4f4
Copy link
Contributor

r4f4 commented Apr 23, 2024

So we'll need 2 feature gates to use a capi provider? ClusterAPIInstall and then ClusterAPIInstallAWS for AWS, e.g.

@JoelSpeed
Copy link
Contributor

So we'll need 2 feature gates to use a capi provider? ClusterAPIInstall and then ClusterAPIInstallAWS for AWS, e.g.

I would expect it to be an or semantic. We want to start adding each of these to the TPNU set as they mature, but the original gate will stay for custom setups only.

@patrickdillon Do you have a PR for the installer that pairs with this?

@patrickdillon
Copy link
Contributor Author

patrickdillon commented Apr 24, 2024

So we'll need 2 feature gates to use a capi provider? ClusterAPIInstall and then ClusterAPIInstallAWS for AWS, e.g.

I would expect it to be an or semantic. We want to start adding each of these to the TPNU set as they mature, but the original gate will stay for custom setups only.

@patrickdillon Do you have a PR for the installer that pairs with this?

+1 I did keep the original feature gate to enable for all platforms (would be fine to remove), but you can an enable individual platforms with a single platform. Opened: openshift/installer#8311

@JoelSpeed
Copy link
Contributor

/lgtm

Scanned over the installer PR and seems like what I was expecting

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 29a704b and 2 for PR HEAD 7d9df7e in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

@patrickdillon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 7d9df7e link false /test e2e-azure

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e1deb89 and 1 for PR HEAD 7d9df7e in total

@patrickdillon
Copy link
Contributor Author

/skip

@openshift-merge-bot openshift-merge-bot bot merged commit cb0966a into openshift:master Apr 25, 2024
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.17.0-202404250047.p0.gcb0966a.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants