features: add capi-installer gate per platform#1868
features: add capi-installer gate per platform#1868openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
Conversation
Adds a capi-installer feature gate for each platform.
|
Hello @patrickdillon! Some important instructions when contributing to openshift/api: |
|
So we'll need 2 feature gates to use a capi provider? |
I would expect it to be an or semantic. We want to start adding each of these to the TPNU set as they mature, but the original gate will stay for custom setups only. @patrickdillon Do you have a PR for the installer that pairs with this? |
+1 I did keep the original feature gate to enable for all platforms (would be fine to remove), but you can an enable individual platforms with a single platform. Opened: openshift/installer#8311 |
|
/lgtm Scanned over the installer PR and seems like what I was expecting |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@patrickdillon: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/skip |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-api-container-v4.17.0-202404250047.p0.gcb0966a.assembly.stream.el9 for distgit ose-cluster-config-api. |
Adds a capi-installer feature gate for each platform.
/cc @JoelSpeed @deads2k
FYI:
@r4f4
@jhixson74
@bfournie
@cjschaef
@yanhua121
@stephenfin
@mjturek
@rvanderp3