-
Notifications
You must be signed in to change notification settings - Fork 585
[OCPNODE-1671] ImagePolicy uses byte format for base64 fields #1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
|
Hello @QiWang19! Some important instructions when contributing to openshift/api: |
Signed-off-by: Qi Wang <[email protected]>
|
@QiWang19 Can you please provide a PR description to explain why we are making this change, and link to the initial PR that introduced these fields? Do we have a bug report? |
|
GoPlayground shows this is a compatible type change from a json serialisation perspective |
|
@JoelSpeed update the description #1765 (comment) |
|
/lgtm |
|
joel intended for this merge /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, JoelSpeed, QiWang19 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@QiWang19: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-api-container-v4.16.0-202402150209.p0.ge741d64.assembly.stream.el9 for distgit ose-cluster-config-api. |
suggested from openshift/machine-config-operator#4160 (comment).
In the code, we need to use []byte format of base64 data, but []byte will be encoded/decoded when JSON marshal/unmarshal, so set the original field to byte so we do not need to process the data type in the code.