Skip to content

Conversation

@QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Feb 10, 2024

suggested from openshift/machine-config-operator#4160 (comment).
In the code, we need to use []byte format of base64 data, but []byte will be encoded/decoded when JSON marshal/unmarshal, so set the original field to byte so we do not need to process the data type in the code.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2024

Hello @QiWang19! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 10, 2024
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2024
@QiWang19 QiWang19 changed the title Update fulcioCAData format to byte ImagePolicy uses byte format for base64 fields Feb 11, 2024
@QiWang19 QiWang19 marked this pull request as ready for review February 11, 2024 04:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2024
@openshift-ci openshift-ci bot requested review from JoelSpeed and sjenning February 11, 2024 04:43
@JoelSpeed
Copy link
Contributor

@QiWang19 Can you please provide a PR description to explain why we are making this change, and link to the initial PR that introduced these fields? Do we have a bug report?

@JoelSpeed
Copy link
Contributor

GoPlayground shows this is a compatible type change from a json serialisation perspective

@QiWang19
Copy link
Member Author

@JoelSpeed update the description #1765 (comment)

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@QiWang19 QiWang19 changed the title ImagePolicy uses byte format for base64 fields [OCPNODE-1671] ImagePolicy uses byte format for base64 fields Feb 13, 2024
@deads2k
Copy link
Contributor

deads2k commented Feb 14, 2024

joel intended for this merge

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed, QiWang19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202402150209.p0.ge741d64.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants